--- /dev/null
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 8B7F5431FBC\r
+ for <notmuch@notmuchmail.org>; Wed, 13 Nov 2013 01:03:51 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.723\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.723 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+ FREEMAIL_REPLY=2.499, HS_INDEX_PARAM=0.023, RCVD_IN_DNSWL_LOW=-0.7]\r
+ autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id tjYwgbe2iU3J for <notmuch@notmuchmail.org>;\r
+ Wed, 13 Nov 2013 01:03:47 -0800 (PST)\r
+Received: from mail-bk0-f43.google.com (mail-bk0-f43.google.com\r
+ [209.85.214.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id F3B16431FB6\r
+ for <notmuch@notmuchmail.org>; Wed, 13 Nov 2013 01:03:46 -0800 (PST)\r
+Received: by mail-bk0-f43.google.com with SMTP id mz13so170640bkb.30\r
+ for <notmuch@notmuchmail.org>; Wed, 13 Nov 2013 01:03:44 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:cc:subject:date:message-id;\r
+ bh=WhM6SV1kOLWMIjZYEPq1Sobvyl0BWy3YptJ2AGxwWXQ=;\r
+ b=HmR6QOpT9d19Manruuq3LhqjyedHCPGSxOcZRbztUMKTMeTr1iNHYlY0pNN3RJzl51\r
+ vEJtixaUe5lSTV7cBQwGPWj22WPOj+1/6B8pVfgKmqK9mCVBWWzAjEntDNaDtNhEwAdV\r
+ 7khD5HLWwYxSvESRiiJ1TommLLRKf7OulhAM5B3cMXHtApRDhv/mKQ5qmdlg0F4obVOE\r
+ JmgcPll93kAStYUWbKgH80iKI+vi8Ubx0aIlOP3vHQrfgqZKJIMYtXyqalTccqIgn9mE\r
+ mJ/sd5RA+v/boRL96BQ3Lj19WCJs3q4U1dRizlmR3xkLj37r0JzzVoJteEt5YGl8uzMN\r
+ xxCA==\r
+X-Received: by 10.204.102.71 with SMTP id f7mr416071bko.57.1384333421849;\r
+ Wed, 13 Nov 2013 01:03:41 -0800 (PST)\r
+Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31])\r
+ by mx.google.com with ESMTPSA id\r
+ kk2sm21457381bkb.10.2013.11.13.01.03.41 for <multiple recipients>\r
+ (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+ Wed, 13 Nov 2013 01:03:41 -0800 (PST)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH] emacs: show: stop stderr appearing in buffer\r
+Date: Wed, 13 Nov 2013 09:03:37 +0000\r
+Message-Id: <1384333417-13832-1-git-send-email-markwalters1009@gmail.com>\r
+X-Mailer: git-send-email 1.7.9.1\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 13 Nov 2013 09:03:51 -0000\r
+\r
+In emacs 24.3+ the stdout/stderr from externally displaying an\r
+attachment gets inserted into the show buffer. This is caused by\r
+changes in mm-display-external in mm-decode.el.\r
+\r
+Ideally, we would put this output in the notmuch errors buffer but the\r
+handler is called asynchronously so we don't know when the output will\r
+appear. Thus if we put it straight into the errors buffer it could get\r
+interleaved with other errors. Also we can't easily tell when we\r
+have got all the error output so can't wait until the process is complete.\r
+\r
+One solution would be to create a new buffer for the stderr of each\r
+attachment viewed. Again, since we can't tell when the process has\r
+finished, we can't close these buffers automatically so this will\r
+leave lots of buffers around.\r
+\r
+Thus we add a debug variable notmuch-show-attachment-debug: it this is\r
+non-nil we create a new buffer for each viewer; if this variable is\r
+nil we just use a temp buffer which means all error output is\r
+discarded (this is the same behaviour as with emacs pre 24.3).\r
+---\r
+\r
+This is a new version of\r
+id:1378502198-7980-1-git-send-email-markwalters1009@gmail.com I don't\r
+think there was complete consensus on the right thing to do here but\r
+most people wanted at least the option of seeing the stderr/stdout.\r
+\r
+This keeps the default behaviour the same as before, but adds a debug\r
+variable to put the stderr/stdout in its own buffer.\r
+\r
+Note: I always use emacs 23 so this is not heavily tested.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+ emacs/notmuch-show.el | 12 +++++++++++-\r
+ 1 files changed, 11 insertions(+), 1 deletions(-)\r
+\r
+diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+index f00273a..f9a3344 100644\r
+--- a/emacs/notmuch-show.el\r
++++ b/emacs/notmuch-show.el\r
+@@ -159,6 +159,8 @@ indentation."\r
+ (make-variable-buffer-local 'notmuch-show-indent-content)\r
+ (put 'notmuch-show-indent-content 'permanent-local t)\r
+ \r
++(defvar notmuch-show-attachment-debug nil)\r
++\r
+ (defcustom notmuch-show-stash-mlarchive-link-alist\r
+ '(("Gmane" . "http://mid.gmane.org/")\r
+ ("MARC" . "http://marc.info/?i=")\r
+@@ -2089,8 +2091,16 @@ caller is responsible for killing this buffer as appropriate."\r
+ This ensures that the temporary buffer created for the mm-handle\r
+ is destroyed when FN returns."\r
+ (let ((handle (notmuch-show-current-part-handle)))\r
++ ;; emacs 24.3+ puts stdout/stderr into the calling buffer so we\r
++ ;; call it from a temp-buffer, unless\r
++ ;; notmuch-show-attachment-debug is non-nil in which case we put\r
++ ;; it in " *notmuch-part*".\r
+ (unwind-protect\r
+- (funcall fn handle)\r
++ (if notmuch-show-attachment-debug\r
++ (with-current-buffer (generate-new-buffer " *notmuch-part*")\r
++ (funcall fn handle))\r
++ (with-temp-buffer\r
++ (funcall fn handle)))\r
+ (kill-buffer (mm-handle-buffer handle)))))\r
+ \r
+ (defun notmuch-show-part-button-default (&optional button)\r
+-- \r
+1.7.9.1\r
+\r
projects / notmuch-archives.git / commitdiff