Re: [PATCH v4 02/16] Move crypto.c into libutil

diff --git a/ff/cb2f4b56c3a30c864fea74fbacdaeddb3748e1 b/ff/cb2f4b56c3a30c864fea74fbacdaeddb3748e1
new file mode 100644 (file)
index 0000000..99e7dbf
--- /dev/null
+++ b/ff/cb2f4b56c3a30c864fea74fbacdaeddb3748e1
@@ -0,0 +1,73 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 69BFC6DE00DB\r
+ for <notmuch@notmuchmail.org>; Sun,  7 Aug 2016 06:33:14 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.008\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.008 tagged_above=-999 required=5 tests=[AWL=0.003,\r
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id fMtYxX4Pu6qP for <notmuch@notmuchmail.org>;\r
+ Sun,  7 Aug 2016 06:33:06 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 8AD646DE0217\r
+ for <notmuch@notmuchmail.org>; Sun,  7 Aug 2016 06:33:01 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1bWOCX-0007T2-Ae; Sun, 07 Aug 2016 09:33:13 -0400\r
+Received: (nullmailer pid 30865 invoked by uid 1000);\r
+ Sun, 07 Aug 2016 13:32:54 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v4 02/16] Move crypto.c into libutil\r
+In-Reply-To: <1467970047-8013-3-git-send-email-dkg@fifthhorseman.net>\r
+References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1467970047-8013-3-git-send-email-dkg@fifthhorseman.net>\r
+User-Agent: Notmuch/0.22.1+61~g2ce0f13 (https://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 07 Aug 2016 22:32:54 +0900\r
+Message-ID: <87h9awu2k9.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 07 Aug 2016 13:33:14 -0000\r
+\r
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+\r
+> This prepares us for using the crypto object in both the library and\r
+> the client.\r
+>\r
+> i've prefixed notmuch_crypto with _ to indicate that while this can be\r
+> built into the library when needed, it's not something to be exported\r
+> or used externally.\r
+\r
+I started to review this series on top of [1], but I didn't get\r
+much past here because of the build failure. I guess there will be at\r
+least one more small change needed because of the alternative way I\r
+ended up doing "remove all properties".  I find\r
+\r
+% git rebase -i -x "make test"\r
+\r
+an effective way of making sure things are in a good state after every\r
+patch. At least it's effective when I remember to do it; just before\r
+writing this, I discovered a rebasing error in [1] that caused a similar\r
+build failure. \r
+\r
+[1]: id:1470491559-3946-1-git-send-email-david@tethera.net\r