Re: [PATCH v3 0/4] cli: notmuch tag/restore refactoring

diff --git a/16/ccc913cde335d1643855ae684a15012fe51e2c b/16/ccc913cde335d1643855ae684a15012fe51e2c
new file mode 100644 (file)
index 0000000..3fd34d2
--- /dev/null
+++ b/16/ccc913cde335d1643855ae684a15012fe51e2c
@@ -0,0 +1,92 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2CCD8431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 28 Mar 2012 22:59:21 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id poQUzZqZseKm for <notmuch@notmuchmail.org>;\r
+       Wed, 28 Mar 2012 22:59:20 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU\r
+       [18.9.25.13])\r
+       by olra.theworths.org (Postfix) with ESMTP id 292B3431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 28 Mar 2012 22:59:20 -0700 (PDT)\r
+X-AuditID: 1209190d-b7fbf6d0000008ba-14-4f73fa372c2b\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+       by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 43.C0.02234.73AF37F4; Thu, 29 Mar 2012 01:59:19 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q2T5xJRB010812; \r
+       Thu, 29 Mar 2012 01:59:19 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q2T5xHEM013236\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Thu, 29 Mar 2012 01:59:18 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1SD8OD-0006uC-Kh; Thu, 29 Mar 2012 01:59:17 -0400\r
+Date: Thu, 29 Mar 2012 01:59:17 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Jani Nikula <jani@nikula.org>\r
+Subject: Re: [PATCH v3 0/4] cli: notmuch tag/restore refactoring\r
+Message-ID: <20120329055917.GC2670@mit.edu>\r
+References: <cover.1332795415.git.jani@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <cover.1332795415.git.jani@nikula.org>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42IRYrdT1zX/Vexv0HNOx6JpurPF9ZszmS3e\r
+       rJzH6sDscfjrQhaPW/dfs3s8W3WLOYA5issmJTUnsyy1SN8ugSvjz/HPTAVHWCo65/9gaWA8\r
+       ytzFyMEhIWAi0bWCp4uRE8gUk7hwbz1bFyMXh5DAPkaJCafmM0M4Gxglnq2/ApU5ySSx4PAD\r
+       KGcJo8Tpn0/YQPpZBFQl1jfeZAKx2QQ0JLbtX84IYosIKEpsPrkfzGYW0JdYeXImM4gtLOAg\r
+       8aVzPwuIzSugLfHu5yWwXiEBI4lJ+74wQ8QFJU7OfMIC0aslcePfSyaQs5kFpCWW/+MACXMK\r
+       GEs0TP4ENl5UQEViysltbBMYhWYh6Z6FpHsWQvcCRuZVjLIpuVW6uYmZOcWpybrFyYl5ealF\r
+       ukZ6uZkleqkppZsYQYHOKcm7g/HdQaVDjAIcjEo8vKc0i/2FWBPLiitzDzFKcjApifKe+w4U\r
+       4kvKT6nMSCzOiC8qzUktPsQowcGsJMLrfg4ox5uSWFmVWpQPk5LmYFES51XVeucnJJCeWJKa\r
+       nZpakFoEk5Xh4FCS4K36CdQoWJSanlqRlplTgpBm4uAEGc4DNLwOpIa3uCAxtzgzHSJ/ilFR\r
+       Spw3GCQhAJLIKM2D64UloleM4kCvCPPGglTxAJMYXPcroMFMQIOXHMkHGVySiJCSamBM/NzK\r
+       Fxa4IPSL0rGWzwVCT74yeUisqso6enPBlSPPMyYdWNF35mferDPPXWy0a7zjs2JmbD5343Bh\r
+       wGqhHPnzIlZ9y8vedTBdPvBsz+uK474v3/0OC7af+r9l/cTdG3jtfkop22S6ROy+MN9gxW4x\r
+       3T8te2VrZaSMWt+xhej/9JPb8uNpvJeJEktxRqKhFnNRcSIAVVfJbh8DAAA=\r
+Cc: tomi.ollila@iki.fi, notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 29 Mar 2012 05:59:21 -0000\r
+\r
+Quoth Jani Nikula on Mar 27 at 12:04 am:\r
+> v3 of id:"cover.1332702915.git.jani@nikula.org" with the following\r
+> mostly non-functional changes:\r
+> \r
+>  - add test for the current tagging behaviour in patch 1, and change the\r
+>    test in patch 2 when the behaviour is changed\r
+>  - handle the no tag changes case in _optimize_tag_query() in patch 2\r
+>  - add braces around the "tag_ops[tag_ops_count].remove = (argv[i][0] == '-');"\r
+>    assignment\r
+>  - document the tag_query() function a bit in patch 3\r
+>  - make tag_message() static in patch 4\r
+> \r
+> BR,\r
+> Jani.\r
+\r
+LGTM.\r