Remove unnecessary usage of strncmp() in git-rev-list arg parsing.

Not only is it unnecessary, it incorrectly allows extraneous characters
at the end of the argument.

Junio noticed the --merge-order thing, and Jon points out that if we fix
that one, we should fix --show-breaks too.

diff --git a/rev-list.c b/rev-list.c
index 825006374a0b028b9a1980a2aee494132f3a4145..0d3c7741a59254f62a135a3bd749e38e1b8dfe71 100644 (file)
--- a/rev-list.c
+++ b/rev-list.c
@@ -462,11 +462,11 @@ int main(int argc, char **argv)
                        limited = 1;
                        continue;
                }
-               if (!strncmp(arg, "--merge-order", 13)) {
+               if (!strcmp(arg, "--merge-order")) {
                        merge_order = 1;
                        continue;
                }
-               if (!strncmp(arg, "--show-breaks", 13)) {
+               if (!strcmp(arg, "--show-breaks")) {
                        show_breaks = 1;
                        continue;
                }