Re: [PATCH 0/2] Contrib: Pick: Remove horrible hack

diff --git a/f7/304c5f0db656e5347301b89f032e4c0eee3a05 b/f7/304c5f0db656e5347301b89f032e4c0eee3a05
new file mode 100644 (file)
index 0000000..c513c75
--- /dev/null
+++ b/f7/304c5f0db656e5347301b89f032e4c0eee3a05
@@ -0,0 +1,120 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E3F20431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 01:30:11 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.401\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.401 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id e5vXK5Tq4Z2w for <notmuch@notmuchmail.org>;\r
+       Sun, 30 Jun 2013 01:30:05 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id F3544431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 01:30:04 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1UtD1B-0005D7-8Z; Sun, 30 Jun 2013 09:29:57 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1UtD1B-0001Yr-0H; Sun, 30 Jun 2013 09:29:57 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/2] Contrib: Pick: Remove horrible hack\r
+In-Reply-To: <1369551008-30697-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1369551008-30697-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 30 Jun 2013 09:29:56 +0100\r
+Message-ID: <87sj00xapn.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 8b4131088c5d751e49869592321450d5 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.6\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored 0.6 points. Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  1.0 FREEMAIL_REPLY From and body contain different freemails\r
+       * -0.4 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 30 Jun 2013 08:30:12 -0000\r
+\r
+\r
+Would anyone be able to review (or just test) this pair of patches: they\r
+are smaller and simpler than the diffstat suggests: the second patch is\r
+just 3 extra lines of code (with some whitespace change and commments).\r
+\r
+This pair of patches does remove the worst piece of code in pick: a\r
+sleep loop waiting for the correct message to arrive.\r
+\r
+I should have said that it applies on top of\r
+id:1369550458-30562-1-git-send-email-markwalters1009@gmail.com\r
+\r
+(which is also very simple)\r
+\r
+Many thanks\r
+\r
+Mark\r
+\r
+\r
+\r
+\r
+On Sun, 26 May 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+> Pick used to have one horrible hack: if the user asked it to open the\r
+> first matching message it had to check whether that had arrived (as\r
+> the search is asynchronous) and if not wait and try again. Now the\r
+> opening of the first matching message is called via the pick process\r
+> filter this hack can be removed.\r
+>\r
+> This did reveal the followibg small bug.  Pick shows the subject line\r
+> in the output but if it is the same as the previous line (ignoring re:\r
+> etc) it shows ... If a single message is refreshed (eg for a tag\r
+> update) this was got wrong. The change above triggered this and made\r
+> the test fail as the unread tag was removed from the first matching\r
+> message when it was displayed.\r
+>\r
+> Patch 2/2 fixes this by storing the previous subject with the search result.\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>  \r
+>\r
+> Mark Walters (2):\r
+>   contrib: pick: remove hack notmuch-pick-show-match-message-with-wait\r
+>   contrib: pick: fix refresh result\r
+>\r
+>  contrib/notmuch-pick/notmuch-pick.el |   60 ++++++++++++++++-----------------\r
+>  1 files changed, 29 insertions(+), 31 deletions(-)\r
+>\r
+> -- \r
+> 1.7.9.1\r