Re: [PATCH] build: add "set -e" to version script generation

diff --git a/04/d44e1e10836012e95e14cbfde8abef4af25460 b/04/d44e1e10836012e95e14cbfde8abef4af25460
new file mode 100644 (file)
index 0000000..cf38fde
--- /dev/null
+++ b/04/d44e1e10836012e95e14cbfde8abef4af25460
@@ -0,0 +1,83 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id F0A0C6DE14FD\r
+ for <notmuch@notmuchmail.org>; Mon, 27 Jul 2015 12:36:47 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.955\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.955 tagged_above=-999 required=5 tests=[AWL=0.303, \r
+ SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id L1Wc9mhUF0pp for <notmuch@notmuchmail.org>;\r
+ Mon, 27 Jul 2015 12:36:45 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 0952B6DE14D9\r
+ for <notmuch@notmuchmail.org>; Mon, 27 Jul 2015 12:36:45 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 27AB8100086;\r
+ Mon, 27 Jul 2015 22:36:24 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] build: add "set -e" to version script generation\r
+In-Reply-To: <1438022552-24342-1-git-send-email-david@tethera.net>\r
+References: <1438022552-24342-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.20.2+31~g967a7a3 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 27 Jul 2015 22:36:23 +0300\r
+Message-ID: <m2a8uh75qg.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 27 Jul 2015 19:36:48 -0000\r
+\r
+On Mon, Jul 27 2015, David Bremner <david@tethera.net> wrote:\r
+\r
+> It turns out that on certain systems like FreeBSD, c++filt is not\r
+> installed by default. It's basically OK if we fail the build in that\r
+> case, but what's really not OK is for the build to continue and\r
+> generate bad binaries.\r
+> ---\r
+>  lib/gen-version-script.sh | 1 +\r
+>  1 file changed, 1 insertion(+)\r
+>\r
+> diff --git a/lib/gen-version-script.sh b/lib/gen-version-script.sh\r
+> index 64a7374..aa1ca43 100644\r
+> --- a/lib/gen-version-script.sh\r
+> +++ b/lib/gen-version-script.sh\r
+> @@ -1,3 +1,4 @@\r
+> +set -e\r
+\r
+LGTM, although I'd prefer 'set -eu' (both visual observation and testing\r
+with set -eux worked for me).\r
+\r
+Tomi\r
+\r
+\r
+>  \r
+>  # we go through a bit of work to get the unmangled names of the\r
+>  # typeinfo symbols because of\r
+> -- \r
+> 2.1.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r