Re: [PATCH] don't store temporary value returned from c_str()

diff --git a/4c/4a1e2ee3624e19eda1f0c700b52b5a29ab1a02 b/4c/4a1e2ee3624e19eda1f0c700b52b5a29ab1a02
new file mode 100644 (file)
index 0000000..207d002
--- /dev/null
+++ b/4c/4a1e2ee3624e19eda1f0c700b52b5a29ab1a02
@@ -0,0 +1,75 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 9D76F431FB6\r
+       for <notmuch@notmuchmail.org>; Sat, 27 Apr 2013 04:53:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id fNDiboiXcKab for <notmuch@notmuchmail.org>;\r
+       Sat, 27 Apr 2013 04:53:44 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 20DCF431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 27 Apr 2013 04:53:44 -0700 (PDT)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1UW3hD-0002zs-Rp; Sat, 27 Apr 2013 08:53:40 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1UW3h8-00088q-4f; Sat, 27 Apr 2013 08:53:34 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Vladimir Marek <Vladimir.Marek@Oracle.COM>,\r
+       Tomi Ollila <tomi.ollila@iki.fi>\r
+Subject: Re: [PATCH] don't store temporary value returned from c_str()\r
+In-Reply-To: <20130427101134.GI10394@pub.cz.oracle.com>\r
+References: <1366405933-17223-1-git-send-email-Vladimir.Marek@oracle.com>\r
+       <m2sj2cjp2b.fsf@guru.guru-group.fi>\r
+       <20130427101134.GI10394@pub.cz.oracle.com>\r
+User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 27 Apr 2013 08:53:33 -0300\r
+Message-ID: <8738ucw5oi.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+Cc: notmuch@notmuchmail.org, Vladimir Marek <vlmarek@volny.cz>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 27 Apr 2013 11:53:46 -0000\r
+\r
+Vladimir Marek <Vladimir.Marek@Oracle.COM> writes:\r
+\r
+>\r
+> const char*\r
+> string::c_str(void) {\r
+>      char buf[100];\r
+>\r
+>      strcpy (buf, this->internal_representation);\r
+>      return buf;\r
+> }\r
+\r
+Isn't that undefined behavior, returning a pointer to a (non-static)\r
+local variable?\r
+\r
+d\r