Re: [Patch v3] util: add gzreadline
authorTomi Ollila <tomi.ollila@iki.fi>
Sun, 30 Mar 2014 16:13:36 +0000 (19:13 +0300)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:01:05 +0000 (10:01 -0800)
d8/d38193d10416520bb3c091ac4b47139bc04e2a [new file with mode: 0644]

diff --git a/d8/d38193d10416520bb3c091ac4b47139bc04e2a b/d8/d38193d10416520bb3c091ac4b47139bc04e2a
new file mode 100644 (file)
index 0000000..361858a
--- /dev/null
@@ -0,0 +1,80 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 76B16431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 30 Mar 2014 09:13:52 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id PoIG7DtgKe08 for <notmuch@notmuchmail.org>;\r
+       Sun, 30 Mar 2014 09:13:44 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id B9A8D431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 30 Mar 2014 09:13:44 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 1CE1E10005E;\r
+       Sun, 30 Mar 2014 19:13:37 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v3] util: add gzreadline\r
+In-Reply-To: <877g7beos0.fsf@zancas.localnet>\r
+References: <m2zjk8um02.fsf@guru.guru-group.fi>\r
+       <1396178602-7583-1-git-send-email-david@tethera.net>\r
+       <m2txafvori.fsf@guru.guru-group.fi>\r
+       <877g7beos0.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.17+171~g9a127b7 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 30 Mar 2014 19:13:36 +0300\r
+Message-ID: <m2r45jwtov.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 30 Mar 2014 16:13:52 -0000\r
+\r
+On Sun, Mar 30 2014, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>> "On error, gzgets() shall return Z_NULL.\r
+>>\r
+>> In light of this I'd say no. can we set out-of-memory using some public\r
+>> api so it is available using gzerror()\r
+>>\r
+>>\r
+>\r
+> Since we already "broke" the API, what about\r
+>\r
+> 1) start a "util_status_t" enum, later unify that with the hex_ return codes.\r
+>\r
+> 2) \r
+>\r
+> util_status_t\r
+> gz_getline (void *ctx, char **buf, size_t *bufsize, ssize_t *bytes_read,\r
+>            gzFile stream);\r
+\r
+that looks unobjectionable to me :D\r
+\r
+>\r
+> d\r
+\r
+Tomi\r