lib: note remaining uses of deprecated message search API

The two remaining cases in the lib seem to require more than a simple
replacement of the old call, with the new call plus a check of the
return value.

diff --git a/lib/database.cc b/lib/database.cc
index bab333412de1c9edb713b222ebad0400b6cf8987..b3ffd04dad56ae484544d55cb2e8208961f6004d 100644 (file)
--- a/lib/database.cc
+++ b/lib/database.cc
@@ -1441,6 +1441,8 @@ notmuch_database_upgrade (notmuch_database_t *notmuch,
        notmuch_message_t *message;
        char *filename;
 
+       /* XXX: this should use the _st version, but needs an error
+          path */
        for (messages = notmuch_query_search_messages (query);
             notmuch_messages_valid (messages);
             notmuch_messages_move_to_next (messages))

diff --git a/lib/thread.cc b/lib/thread.cc
index 9847cf8bfc868d6b63e24a8ff56eb2943e997d36..c8e58c336e46e6dcfc45a15bf78b7182643cb421 100644 (file)
--- a/lib/thread.cc
+++ b/lib/thread.cc
@@ -504,6 +504,8 @@ _notmuch_thread_create (void *ctx,
      * oldest or newest subject is desired. */
     notmuch_query_set_sort (thread_id_query, NOTMUCH_SORT_OLDEST_FIRST);
 
+    /* XXX: this should use the _st version, but it needs an error path
+     */
     for (messages = notmuch_query_search_messages (thread_id_query);
         notmuch_messages_valid (messages);
         notmuch_messages_move_to_next (messages))