Re: [PATCH] notmuch-mutt: replace gnu sed and xargs with perl

diff --git a/9c/30711acf86cff669270170f010b587219a71ea b/9c/30711acf86cff669270170f010b587219a71ea
new file mode 100644 (file)
index 0000000..3bf85bf
--- /dev/null
+++ b/9c/30711acf86cff669270170f010b587219a71ea
@@ -0,0 +1,113 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C7EFC431FAF\r
+       for <notmuch@notmuchmail.org>; Thu, 12 Apr 2012 00:07:57 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id bIriozQ2d-Ng for <notmuch@notmuchmail.org>;\r
+       Thu, 12 Apr 2012 00:07:57 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2D708431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 12 Apr 2012 00:07:57 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 6C47468055; Thu, 12 Apr 2012 10:07:54 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Taylor Carpenter <taylor@codecafe.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] notmuch-mutt: replace gnu sed and xargs with perl\r
+In-Reply-To: <20120412002953.GA27056@codecafe.com>\r
+References: <20120412002953.GA27056@codecafe.com>User-Agent:\r
+ Notmuch/0.12+77~gee11800      (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 12 Apr 2012 10:07:54 +0300\r
+Message-ID: <m2r4vtjulx.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 12 Apr 2012 07:07:57 -0000\r
+\r
+On Thu, Apr 12 2012, Taylor Carpenter wrote:\r
+\r
+> External software dependencies removed: sed and xargs.\r
+>\r
+> Sed shell escaping is handled automatically with perl symlink function.\r
+>\r
+> The xargs usage is specific to gnu xargs (fails on bsd xargs, etc).\r
+>\r
+> NOTE: The current query pulls the list of files into an array all at\r
+> once.  The larger the list the more memory used.\r
+> ---\r
+\r
+-1\r
+\r
+It is not too hard to read the filelist from pipe; Check the example\r
+I sent in id:"m2hawr4klm.fsf@guru.guru-group.fi"\r
+\r
+\r
+Btw: what if there are same filenames in different directories that\r
+match. With basename there will be collision. Alternatives:\r
+\r
+* instead of basename convert '/':s to '_':s\r
+* take md5 or sha1 sum of the filename\r
+* take md5 or sha1 sum of dirname of the filename and concatenate...\r
+\r
+Tomi\r
+\r
+>  contrib/notmuch-mutt/notmuch-mutt |    9 ++++++---\r
+>  1 files changed, 6 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt\r
+> index 424f9a3..c995022 100755\r
+> --- a/contrib/notmuch-mutt/notmuch-mutt\r
+> +++ b/contrib/notmuch-mutt/notmuch-mutt\r
+> @@ -12,6 +12,7 @@ use strict;\r
+>  use warnings;\r
+>  \r
+>  use File::Path;\r
+> +use File::Basename;\r
+>  use Getopt::Long qw(:config no_getopt_compat);\r
+>  use Mail::Internet;\r
+>  use Mail::Box::Maildir;\r
+> @@ -41,9 +42,11 @@ sub search($$) {\r
+>      $query = shell_quote($query);\r
+>  \r
+>      empty_maildir($maildir);\r
+> -    system("notmuch search --output=files $query"\r
+> -       . " | sed -e 's: :\\\\ :g'"\r
+> -       . " | xargs --no-run-if-empty ln -s -t $maildir/cur/");\r
+> +    my @filelist = `notmuch search --output=files $query`;\r
+> +    foreach(@filelist) {\r
+> +        chomp;\r
+> +        symlink($_, "$maildir/cur/" . basename($_));\r
+> +    }\r
+>  }\r
+>  \r
+>  sub prompt($$) {\r
+> -- \r
+> 1.7.7.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r