Re: [PATCH v2 0/3] Better id: link buttonization

diff --git a/9f/f4ed36654e8f3d490300e4c85ea65fb841d035 b/9f/f4ed36654e8f3d490300e4c85ea65fb841d035
new file mode 100644 (file)
index 0000000..57ba726
--- /dev/null
+++ b/9f/f4ed36654e8f3d490300e4c85ea65fb841d035
@@ -0,0 +1,80 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1B5ED431FBC\r
+       for <notmuch@notmuchmail.org>; Wed, 14 Nov 2012 00:32:23 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id EOiP1rh7s3TT for <notmuch@notmuchmail.org>;\r
+       Wed, 14 Nov 2012 00:32:22 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2BA89431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 14 Nov 2012 00:32:22 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 563AB1000E2;\r
+       Wed, 14 Nov 2012 10:32:20 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>,\r
+       Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/3] Better id: link buttonization\r
+In-Reply-To: <87k3to6h9p.fsf@betacantrips.com>\r
+References: <1352609175-12790-1-git-send-email-amdragon@mit.edu>\r
+       <87k3to6h9p.fsf@betacantrips.com>\r
+User-Agent: Notmuch/0.14+84~g8a199bf (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 14 Nov 2012 10:32:19 +0200\r
+Message-ID: <m2obj0ega4.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: sascha-ml-reply-to-2012-4@silbe.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 14 Nov 2012 08:32:23 -0000\r
+\r
+On Wed, Nov 14 2012, Ethan Glasser-Camp wrote:\r
+\r
+> Austin Clements <amdragon@MIT.EDU> writes:\r
+>\r
+>> This is v2 of id:"1351650561-7331-1-git-send-email-amdragon@mit.edu".\r
+>> This makes Jani's suggested additions to the regexp and adds support\r
+>> for RFC 2392 mid: links, as suggested by Sascha.\r
+>\r
+> This series looks fine to me.\r
+\r
+LGTM too. \r
+\r
+although this is different than others in test/emacs:\r
+\r
+ +test_expect_equal_file EXPECTED OUTPUT\r
+\r
+(grep test_expect_equal_file test/emacs)\r
+\r
+The diff output in case of failure makes more sense when the args\r
+are in this order -- but probably that should be changed\r
+bu changing the arg handling order in test_expect_equal_file\r
+(to be consistent with test_expect_equal) and then change the order\r
+in the "remaining" uses of test_expect_equal_file EXPECTED OUTPUT.\r
+\r
+> Ethan\r
+\r
+Tomi\r