Re: notmuch_thread_get_authors

diff --git a/ab/91fe744133a9a6d321f9c692e64b43aae5fdb5 b/ab/91fe744133a9a6d321f9c692e64b43aae5fdb5
new file mode 100644 (file)
index 0000000..cf7a8f8
--- /dev/null
+++ b/ab/91fe744133a9a6d321f9c692e64b43aae5fdb5
@@ -0,0 +1,106 @@
+Return-Path: <aclements@csail.mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 9A18F6DE1A2F\r
+ for <notmuch@notmuchmail.org>; Tue, 21 Apr 2015 18:40:28 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.622\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.622 tagged_above=-999 required=5 tests=[AWL=2.229,\r
+  RCVD_IN_DNSWL_MED=-2.3, RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 2P1u7_FK1_5N for <notmuch@notmuchmail.org>;\r
+ Tue, 21 Apr 2015 18:40:25 -0700 (PDT)\r
+X-Greylist: delayed 713 seconds by postgrey-1.35 at arlo;\r
+ Tue, 21 Apr 2015 18:40:24 PDT\r
+Received: from outgoing.csail.mit.edu (outgoing.csail.mit.edu [128.30.2.149])\r
+ by arlo.cworth.org (Postfix) with ESMTP id C635C6DE1A2E\r
+ for <notmuch@notmuchmail.org>; Tue, 21 Apr 2015 18:40:24 -0700 (PDT)\r
+Received: from [104.131.20.129] (helo=awakeningjr)\r
+ by outgoing.csail.mit.edu with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16)\r
+ (Exim 4.72) (envelope-from <aclements@csail.mit.edu>)\r
+ id 1YkjSl-0008Qn-Ln; Tue, 21 Apr 2015 21:28:27 -0400\r
+Received: from amthrax by awakeningjr with local (Exim 4.84)\r
+ (envelope-from <aclements@csail.mit.edu>)\r
+ id 1YkjSk-0007Bx-Sd; Tue, 21 Apr 2015 21:28:26 -0400\r
+From: Austin Clements <aclements@csail.mit.edu>\r
+To: Ronny Chevalier <chevalier.ronny@gmail.com>,\r
+ David Bremner <david@tethera.net>\r
+Subject: Re: notmuch_thread_get_authors\r
+In-Reply-To:\r
+ <CABPZE7JGzfSMWKpxKqJeCbpsDhX4xj_HoNoKFL8MbYv9xYpQ7w@mail.gmail.com>\r
+References:\r
+ <CABPZE7L5yX3tJH+1vMotxL7BHYoQd2BJSbzFuKTAxHgC5+6RHA@mail.gmail.com>\r
+ <87618qfk5l.fsf@maritornes.cs.unb.ca>\r
+ <CABPZE7JGzfSMWKpxKqJeCbpsDhX4xj_HoNoKFL8MbYv9xYpQ7w@mail.gmail.com>\r
+User-Agent: Notmuch/0.19+38~g8fb1cbc (http://notmuchmail.org) Emacs/24.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 21 Apr 2015 21:28:26 -0400\r
+Message-ID: <87lhhlhryd.fsf@csail.mit.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 22 Apr 2015 01:40:28 -0000\r
+\r
+On Tue, 21 Apr 2015, Ronny Chevalier <chevalier.ronny@gmail.com> wrote:\r
+> On Tue, Apr 21, 2015 at 1:35 AM, David Bremner <david@tethera.net> wrote:\r
+>> Ronny Chevalier <chevalier.ronny@gmail.com> writes:\r
+> Austin Clements wrote:\r
+>> And I think there's a fairly easy way to do it in C code that will\r
+>> also prevent library interface bloat: instead of introducing new\r
+>> library APIs to get at this information, just use the existing\r
+>> notmuch_thread_get_messages API and construct the matched and\r
+>> non-matched lists in the CLI.  Doing it in the CLI wouldn't require\r
+>> the library to export yet another string list structure, which is\r
+>> always a huge pain (thanks C!), and wouldn't introduce more "helper"\r
+>> functions into the library API.\r
+>\r
+> I disagree with what Austin said. Because this does not solve the\r
+> issue at all (or I misunderstood). The issue is with the notmuch API,\r
+> if someone is using this library there no way it can parse properly\r
+> the authors.\r
+> In my case I am not using the CLI but the notmuch library, fixing this\r
+> in the CLI is just an hack, and it does not fix the issue for the\r
+> library users.\r
+\r
+My suggestion was in no way specific to the CLI. That was the context of\r
+the discussion at the time, but for the purposes of this discussion, the\r
+CLI is just another library user.\r
+\r
+You're completely right that there's no way to reliably parse the\r
+authors list returned by notmuch_thread_get_authors. So don't do\r
+that. Just use notmuch_thread_get_messages, walk the messages list, and\r
+build your own authors list. There's no need to introduce additional\r
+complexity and surface area into the library API for this specific use\r
+case (IMO, even notmuch_thread_get_authors shouldn't exist, but it's\r
+there for legacy reasons.) Then you can get author lists for matched,\r
+non-matched, matching a specific tag, just the to, just the from, counts\r
+of how many times each author appeared, whatever you want.\r
+\r
+> Furthermore, I do not see why providing a string list NULL-terminated\r
+> in C is a huge pain?\r
+\r
+See the notmuch_tags_* and notmuch_filesnames_* APIs. Those are just\r
+string lists.\r
+\r
+> Otherwise, I agree with Mark Walters comments on the patch.\r
+>\r
+> If no one is working to fix this at the moment, I can send a patch?\r
+>\r
+> Ronny\r