[PATCH 1/4] contrib: pick: print () for a message with no tags

diff --git a/ac/0019617a9a4cb2848345d16718cb170d3d3aa4 b/ac/0019617a9a4cb2848345d16718cb170d3d3aa4
new file mode 100644 (file)
index 0000000..a736bd2
--- /dev/null
+++ b/ac/0019617a9a4cb2848345d16718cb170d3d3aa4
@@ -0,0 +1,92 @@
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 51AD8431FD6\r
+       for <notmuch@notmuchmail.org>; Sun,  1 Sep 2013 20:28:23 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.201\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+       RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id qqCVZkYhSAIU for <notmuch@notmuchmail.org>;\r
+       Sun,  1 Sep 2013 20:28:17 -0700 (PDT)\r
+Received: from mail-we0-f176.google.com (mail-we0-f176.google.com\r
+       [74.125.82.176]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 534EC431FC7\r
+       for <notmuch@notmuchmail.org>; Sun,  1 Sep 2013 20:28:17 -0700 (PDT)\r
+Received: by mail-we0-f176.google.com with SMTP id u56so592084wes.7\r
+       for <notmuch@notmuchmail.org>; Sun, 01 Sep 2013 20:28:15 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:date:message-id:in-reply-to:references;\r
+       bh=ySqqhHVxpqz0zMXb1B+D1my+dvD5e+W80OyfxEwG6BU=;\r
+       b=RsySKvZ51ZKv9LcqgAV/txjLZAYRzp5wlE0Yp44GzJrb9+MC6US1X06DUjErubpnJ0\r
+       y6LCRGbBH5Z5uByZLRNSoYDbqeZrVsiTGiZXgSEuCRpZ5R2H9O5Wz5GuzvJ5S0E4WZab\r
+       38XTdrySxbRAG27Yhf6H8cPq/LoQqvrRaSwk+OkV0AXMQCYMqigvxF4SoBkVwpwZlSpu\r
+       CCKDMv7mqJtFVVWpm9o28jzgX9WguyGTEV4oXiNE7UNdTiyzZsRXhYutsuJ1/QeJTi1t\r
+       y/MB1rgbSCtrhlUbOiBgtE8kHw65iYmDj5ftmU4DLTnuzHWUdQy/Y5kY9c0KdZ2C05/T\r
+       nP+w==\r
+X-Received: by 10.180.207.84 with SMTP id lu20mr11830739wic.50.1378092494964; \r
+       Sun, 01 Sep 2013 20:28:14 -0700 (PDT)\r
+Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31])\r
+       by mx.google.com with ESMTPSA id\r
+       fv10sm13582153wic.0.1969.12.31.16.00.00\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Sun, 01 Sep 2013 20:28:14 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH 1/4] contrib: pick: print () for a message with no tags\r
+Date: Mon,  2 Sep 2013 04:28:05 +0100\r
+Message-Id: <1378092488-32050-2-git-send-email-markwalters1009@gmail.com>\r
+X-Mailer: git-send-email 1.7.9.1\r
+In-Reply-To: <1378092488-32050-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1378092488-32050-1-git-send-email-markwalters1009@gmail.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 02 Sep 2013 03:28:23 -0000\r
+\r
+Dating back to the earliest notmuch-pick we have not printed anything\r
+for the tag field for a message with no tags. This is inconsistent\r
+with search and show both of which print "()". Change pick to be\r
+consistent.\r
+---\r
+ contrib/notmuch-pick/notmuch-pick.el |    7 +++----\r
+ 1 files changed, 3 insertions(+), 4 deletions(-)\r
+\r
+diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el\r
+index 37dc161..063d660 100644\r
+--- a/contrib/notmuch-pick/notmuch-pick.el\r
++++ b/contrib/notmuch-pick/notmuch-pick.el\r
+@@ -652,10 +652,9 @@ unchanged ADDRESS if parsing fails."\r
+           (face (if match\r
+                         'notmuch-pick-match-tag-face\r
+                       'notmuch-pick-no-match-tag-face)))\r
+-      (when tags\r
+-        (insert (propertize (format format-string\r
+-                                    (mapconcat #'identity tags ", "))\r
+-                            'face face))))))))\r
++      (insert (propertize (format format-string\r
++                                  (mapconcat #'identity tags ", "))\r
++                          'face face)))))))\r
+ \r
+ (defun notmuch-pick-insert-msg (msg)\r
+   "Insert the message MSG according to notmuch-pick-result-format"\r
+-- \r
+1.7.9.1\r
+\r