Re: [PATCH] Avoid empty thread names if possible.

diff --git a/44/2fce7452287f93c340ae6c18d82f5ba0af0233 b/44/2fce7452287f93c340ae6c18d82f5ba0af0233
new file mode 100644 (file)
index 0000000..2bec92a
--- /dev/null
+++ b/44/2fce7452287f93c340ae6c18d82f5ba0af0233
@@ -0,0 +1,68 @@
+Return-Path: <prvs=372b3579b=jrosenthal@jhu.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0E537431FC2\r
+       for <notmuch@notmuchmail.org>; Wed, 29 Oct 2014 06:25:47 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id cF-EKlx50CqQ for <notmuch@notmuchmail.org>;\r
+       Wed, 29 Oct 2014 06:25:41 -0700 (PDT)\r
+X-Greylist: delayed 1093 seconds by postgrey-1.32 at olra;\r
+       Wed, 29 Oct 2014 06:25:41 PDT\r
+Received: from IPMTW1.johnshopkins.edu (ipmtw1.johnshopkins.edu\r
+       [128.220.229.140]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 571A1431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 29 Oct 2014 06:25:40 -0700 (PDT)\r
+X-IronPort-AV: E=Sophos;i="5.04,810,1406606400"; d="scan'208";a="15431611"\r
+Received: from guppy.hwcampus.jhu.edu (HELO localhost) ([10.161.32.234])\r
+       by IPMTW1.johnshopkins.edu with ESMTP/TLS/AES128-SHA;\r
+       29 Oct 2014 09:21:53 -0400\r
+From: Jesse Rosenthal <jrosenthal@jhu.edu>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] Avoid empty thread names if possible.\r
+In-Reply-To: <m2fve7dgg5.fsf@guru.guru-group.fi>\r
+References: <87oatnakqy.fsf@jhu.edu> <m2fve7dgg5.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.18.2+155~gafa8535 (http://notmuchmail.org) Emacs/24.4.1\r
+       (i686-pc-linux-gnu)\r
+Date: Wed, 29 Oct 2014 09:21:52 -0400\r
+Message-ID: <87wq7j9fkf.fsf@jhu.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 29 Oct 2014 13:25:49 -0000\r
+\r
+Thanks for taking a look.\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> IMO it is a bit silly to scan through the whole string and use the return\r
+> value of 0 (vs != 0) to have effect. we should probably have something like\r
+> #define EMPTY_STRING(s) ((s)[0] == '\0') \r
+> and use that instead.\r
+\r
+Good point. Will put in the next version.\r
+\r
+> Also, to keep promise, mentioning 'patch' in commit message referring to \r
+> the change introduced does IMO also look silly :D\r
+\r
+Ah. Yep, agreed.\r
+\r