Re: NOTMUCH_STATUS_LAST_STATUS problematic across additive library upgrades

diff --git a/91/1a8f84fe0eb7c9420f1848fef9f94ba9e6a008 b/91/1a8f84fe0eb7c9420f1848fef9f94ba9e6a008
new file mode 100644 (file)
index 0000000..82c60f4
--- /dev/null
+++ b/91/1a8f84fe0eb7c9420f1848fef9f94ba9e6a008
@@ -0,0 +1,74 @@
+Return-Path: <dkg@fifthhorseman.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id B6DA86DE1378\r
+ for <notmuch@notmuchmail.org>; Mon,  7 Dec 2015 16:19:08 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.077\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.077 tagged_above=-999 required=5\r
+ tests=[AWL=-0.077] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Xhihx-X1ztTk for <notmuch@notmuchmail.org>;\r
+ Mon,  7 Dec 2015 16:19:07 -0800 (PST)\r
+Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])\r
+ by arlo.cworth.org (Postfix) with ESMTP id D42006DE100D\r
+ for <notmuch@notmuchmail.org>; Mon,  7 Dec 2015 16:19:06 -0800 (PST)\r
+Received: from fifthhorseman.net (ool-6c3a0662.static.optonline.net\r
+ [108.58.6.98])\r
+ by che.mayfirst.org (Postfix) with ESMTPSA id 79DA9F984;\r
+ Mon,  7 Dec 2015 19:19:04 -0500 (EST)\r
+Received: by fifthhorseman.net (Postfix, from userid 1000)\r
+ id 301AA1FF49; Mon,  7 Dec 2015 19:19:04 -0500 (EST)\r
+From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>\r
+To: Carl Worth <cworth@cworth.org>,\r
+ notmuch mailing list <notmuch@notmuchmail.org>\r
+Subject: Re: NOTMUCH_STATUS_LAST_STATUS problematic across additive library\r
+ upgrades\r
+In-Reply-To: <87vb89n83m.fsf@wondoo.home.cworth.org>\r
+References: <87y4d5q38i.fsf@alice.fifthhorseman.net>\r
+ <87vb89n83m.fsf@wondoo.home.cworth.org>\r
+User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Mon, 07 Dec 2015 19:19:04 -0500\r
+Message-ID: <87poyhpzbb.fsf@alice.fifthhorseman.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 08 Dec 2015 00:19:08 -0000\r
+\r
+On Mon 2015-12-07 18:37:33 -0500, Carl Worth wrote:\r
+> Can you envision a scenario where this would actually lead to a bug?\r
+>\r
+> It's meant to provide a convenience. It's clearly documented as "not an\r
+> actual status value", so, yes, no client code should ever be passing\r
+> that value into the library.\r
+\r
+The only place a client can pass the value into the library is in\r
+notmuch_status_to_string(), which is actually OK -- the library itself\r
+will be able to tell the client what the status means, even if the\r
+client didn't know about the status value itself.\r
+\r
+I could see some hyper-correct client saying "whoa, we actually got a\r
+status >= NOTMUCH_STATUS_LAST_STATUS; something must be horribly\r
+broken!" and bailing unreasonably, but maybe we can safely say "don't do\r
+that".\r
+\r
+I note that it's exposed in the go bindings -- maybe it shouldn't be\r
+exposed in any of the bindings that can avoid exposing it?\r
+\r
+        --dkg\r