Re: [PATCH v2 1/3] search: Separately report matching and non-matching authors.

diff --git a/9c/658c537a43671b7708c3c549b63e828bb05dc5 b/9c/658c537a43671b7708c3c549b63e828bb05dc5
new file mode 100644 (file)
index 0000000..6d2611d
--- /dev/null
+++ b/9c/658c537a43671b7708c3c549b63e828bb05dc5
@@ -0,0 +1,81 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2CE8A431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 18 Jan 2015 06:20:28 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.438\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.438 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id fieNFDkJeVjm for <notmuch@notmuchmail.org>;\r
+       Sun, 18 Jan 2015 06:20:25 -0800 (PST)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+       [87.98.215.224])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 4E848431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 18 Jan 2015 06:20:25 -0800 (PST)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+       4.80) (envelope-from <david@tethera.net>)\r
+       id 1YCqhU-0006xZ-V1; Sun, 18 Jan 2015 14:19:36 +0000\r
+Received: (nullmailer pid 24147 invoked by uid 1000); Sun, 18 Jan 2015\r
+       14:19:23 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 1/3] search: Separately report matching and\r
+       non-matching    authors.\r
+In-Reply-To: <1414172643-28270-2-git-send-email-dme@dme.org>\r
+References: <1414172643-28270-1-git-send-email-dme@dme.org>\r
+       <1414172643-28270-2-git-send-email-dme@dme.org>\r
+User-Agent: Notmuch/0.19+27~g29ffde4 (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 18 Jan 2015 15:19:23 +0100\r
+Message-ID: <871tms9no4.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 18 Jan 2015 14:20:28 -0000\r
+\r
+David Edmondson <dme@dme.org> writes:\r
+\r
+> In addition to the 'authors' attribute of each search result, include\r
+> 'authors_matched' and 'authors_non_matched' attributes. Both\r
+> attributes are always included and are formatted as a list of\r
+> authors. If there are no matching authors, the 'authors_non_matched'\r
+> attribute is set to the empty list.\r
+> ---\r
+\r
+It would be nicer if the tests were repaired in the same commit, or\r
+minimally marked broken.\r
+\r
+>  static int\r
+>  do_search_threads (sprinter_t *format,\r
+>                 notmuch_query_t *query,\r
+> @@ -152,6 +253,10 @@ do_search_threads (sprinter_t *format,\r
+>              format->integer (format, total);\r
+>              format->map_key (format, "authors");\r
+>              format->string (format, authors);\r
+> +            if (_enumerate_authors (format, thread) < 0) {\r
+> +                fprintf (stderr, "Out of memory\n");\r
+> +                return 1;\r
+> +            }\r
+\r
+Maybe I'm just blind, but I don't see how enumerate authors ever returns\r
+anything other than 0. \r
+\r