Re: [PATCH v4 09/16] index encrypted parts when asked.

diff --git a/07/b85662fb95f3301db5a414e4d05c240e4626c2 b/07/b85662fb95f3301db5a414e4d05c240e4626c2
new file mode 100644 (file)
index 0000000..38dedf9
--- /dev/null
+++ b/07/b85662fb95f3301db5a414e4d05c240e4626c2
@@ -0,0 +1,97 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 52B506DE00F5\r
+ for <notmuch@notmuchmail.org>; Thu, 14 Jul 2016 17:23:36 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.011\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.011 tagged_above=-999 required=5 tests=[AWL=0.000,\r
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Bko8fvonLmUz for <notmuch@notmuchmail.org>;\r
+ Thu, 14 Jul 2016 17:23:26 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id C19426DE00C9\r
+ for <notmuch@notmuchmail.org>; Thu, 14 Jul 2016 17:23:26 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1bNquA-0002Ty-K0; Thu, 14 Jul 2016 20:22:58 -0400\r
+Received: (nullmailer pid 29663 invoked by uid 1000);\r
+ Fri, 15 Jul 2016 00:23:20 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v4 09/16] index encrypted parts when asked.\r
+In-Reply-To: <8737ncmbpy.fsf@alice.fifthhorseman.net>\r
+References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1467970047-8013-10-git-send-email-dkg@fifthhorseman.net>\r
+ <87lh14e2x8.fsf@tesseract.cs.unb.ca> <8737ncmbpy.fsf@alice.fifthhorseman.net>\r
+User-Agent: Notmuch/0.22+28~gb9bf3f4 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Thu, 14 Jul 2016 21:23:20 -0300\r
+Message-ID: <8760s7zr47.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 15 Jul 2016 00:23:36 -0000\r
+\r
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+\r
+> It makes no sense to stop indexing a message just because one of the\r
+> parts failed to decrypt, so i'm not going to immediately return.\r
+>\r
+> I'm willing to accept that only the last log message will make it out to\r
+> the caller, and i could track whether anything has been written to the\r
+> log and change the return value in that case.  would that be acceptable?\r
+>\r
+\r
+That sounds like an improvement. Other options I can think of\r
+\r
+      - accumulate an error string. With talloc_asprintf_append, this is\r
+      not _too_ terrible. Making a second logging function [1] that\r
+      didn't clear the log buffer but appended would maybe make sense\r
+      (aside from contradicting what I said in the previous message).\r
+      This would still need some status return to alert the caller.\r
+\r
+    - Pass a logging callback; this requires API changes.  We\r
+      already have a such a callback for notmuch_database_compact.\r
+      \r
+\r
+While thinking about this, I noticed several suspect uses of\r
+_notmuch_database_log in current index.cc, at least in\r
+_index_mime_part. These are probably my fault, resulting from \r
+blindly replacing printfs.\r
+\r
+[1]: untested:\r
+\r
+void\r
+_notmuch_database_log_append (notmuch_database_t *notmuch,\r
+                     const char *format,\r
+                     ...)\r
+{\r
+    va_list va_args;\r
+\r
+    va_start (va_args, format);\r
+\r
+    if (notmuch->status_string)\r
+       notmuch->status_string = talloc_vasprintf_append (notmuch->status_string, format, va_args)\r
+    else\r
+       notmuch->status_string = talloc_vasprintf (notmuch, format, va_args);\r
+    \r
+    va_end (va_args);\r
+}\r