Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.

diff --git a/5b/5412984e4a867cd8c1189f2c81a1c66db1c343 b/5b/5412984e4a867cd8c1189f2c81a1c66db1c343
new file mode 100644 (file)
index 0000000..a874546
--- /dev/null
+++ b/5b/5412984e4a867cd8c1189f2c81a1c66db1c343
@@ -0,0 +1,83 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2528C431FC0\r
+       for <notmuch@notmuchmail.org>; Sat, 10 May 2014 02:51:07 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id NIjIA6qBd9bz for <notmuch@notmuchmail.org>;\r
+       Sat, 10 May 2014 02:51:00 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+       [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 12C0E431FBF\r
+       for <notmuch@notmuchmail.org>; Sat, 10 May 2014 02:51:00 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+       4.72) (envelope-from <david@tethera.net>)\r
+       id 1Wj3uZ-0006pT-6S; Sat, 10 May 2014 09:49:43 +0000\r
+Received: (nullmailer pid 10909 invoked by uid 1000); Sat, 10 May 2014\r
+       09:49:24 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Charles Celerier <cceleri@cs.stanford.edu>, Notmuch Mail\r
+       <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v2 5/5] T360-symbol-hiding: Use nm instead of objdump.\r
+In-Reply-To: <m2iopfoihw.fsf@jane.lan>\r
+References: <1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu>\r
+       <1399434615-28425-1-git-send-email-cceleri@cs.stanford.edu>\r
+       <1399434615-28425-2-git-send-email-cceleri@cs.stanford.edu>\r
+       <87d2fov2qj.fsf@maritornes.cs.unb.ca> <m2zjisnwie.fsf@jane.lan>\r
+       <87a9arvs9b.fsf@maritornes.cs.unb.ca> <m2iopfoihw.fsf@jane.lan>\r
+User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 10 May 2014 18:49:24 +0900\r
+Message-ID: <87lhua3qvv.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 10 May 2014 09:51:07 -0000\r
+\r
+Charles Celerier <cceleri@cs.stanford.edu> writes:\r
+\r
+> David Bremner <david@tethera.net> writes:\r
+>\r
+>     $ nm --version\r
+>     GNU nm (GNU Binutils) 2.24\r
+>     Copyright 2013 Free Software Foundation, Inc.\r
+>     This program is free software; you may redistribute it under the terms of\r
+>     the GNU General Public License version 3 or (at your option) any later version.\r
+>     This program has absolutely no warranty.\r
+>\r
+> I'm not convinced the insertion of an underscore is nm's doing.\r
+\r
+OIC. right, nm is not the issue.\r
+\r
+> At this point, I'm not sure how to create a better version of this\r
+> patch. Are we renaming functions in notmuch-private.h? Should we stick\r
+> with objdump or switch to using nm?\r
+\r
+I'd go with renaming any functions that start with notmuch to start with\r
+_notmuch.\r
+\r
+Since it seems neither nm nor objdump provides uniform output between\r
+OS/X and Linux, there isn't an obvious advantage to switching to nm. Any\r
+idea if objdump can be made to work (in this test) on OS/X ?\r
+\r
+d\r