Re: [PATCH v2 2/3] contrib: pick: remove hack notmuch-pick-show-match-message-with...

diff --git a/39/a08f218a86e60ec44aa2838e4a5e189ccc72fc b/39/a08f218a86e60ec44aa2838e4a5e189ccc72fc
new file mode 100644 (file)
index 0000000..853b116
--- /dev/null
+++ b/39/a08f218a86e60ec44aa2838e4a5e189ccc72fc
@@ -0,0 +1,68 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 75919431FDB\r
+       for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 20:08:04 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Uqnnn7u7XxD1 for <notmuch@notmuchmail.org>;\r
+       Sun, 30 Jun 2013 20:07:58 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 53646431FDA\r
+       for <notmuch@notmuchmail.org>; Sun, 30 Jun 2013 20:07:58 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UtUT7-0005H2-II; Mon, 01 Jul 2013 00:07:57 -0300\r
+Received: (nullmailer pid 5842 invoked by uid 1000); Mon, 01 Jul 2013\r
+       03:07:53 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 2/3] contrib: pick: remove hack\r
+       notmuch-pick-show-match-message-with-wait\r
+In-Reply-To: <87hagf5mi2.fsf@qmul.ac.uk>\r
+References: <1372582512-10777-1-git-send-email-markwalters1009@gmail.com>\r
+       <1372582512-10777-3-git-send-email-markwalters1009@gmail.com>\r
+       <87li5rtvbh.fsf@zancas.localnet> <87hagf5mi2.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.15.2+193~gb7df509 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Mon, 01 Jul 2013 00:07:53 -0300\r
+Message-ID: <877ghbt1ti.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 01 Jul 2013 03:08:04 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> I am not sure what the best way to document the variable is: there are\r
+> several variables that are essentially buffer local versions of the\r
+> arguments passed to notmuch-pick. Should these duplicate the\r
+> documentation? Exactly the same situation occurs with notmuch-show in\r
+> notmuch-show.el and notmuch-search in notmuch.el and in both those cases\r
+> the functions are well documented but the variables are not documented.\r
+\r
+what about just saying something like "this variable is a buffer local\r
+copy of argument FOO to function BAR" ?\r
+\r
+d\r
+\r