Re: [PATCH 01/24] lib/message.cc: stale pointer bug

diff --git a/b5/a82111691585e04bde6dbfb6a4ea40aab9f120 b/b5/a82111691585e04bde6dbfb6a4ea40aab9f120
new file mode 100644 (file)
index 0000000..bf5d2b0
--- /dev/null
+++ b/b5/a82111691585e04bde6dbfb6a4ea40aab9f120
@@ -0,0 +1,115 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A9E1A431FBC\r
+       for <notmuch@notmuchmail.org>; Thu,  2 May 2013 13:36:41 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id QsySbbVg337W for <notmuch@notmuchmail.org>;\r
+       Thu,  2 May 2013 13:36:37 -0700 (PDT)\r
+Received: from mail-lb0-f174.google.com (mail-lb0-f174.google.com\r
+       [209.85.217.174]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 569D0431FAF\r
+       for <notmuch@notmuchmail.org>; Thu,  2 May 2013 13:36:37 -0700 (PDT)\r
+Received: by mail-lb0-f174.google.com with SMTP id r10so948120lbi.19\r
+       for <notmuch@notmuchmail.org>; Thu, 02 May 2013 13:36:35 -0700 (PDT)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=google.com; s=20120113;\r
+       h=x-received:from:to:cc:subject:in-reply-to:references:user-agent\r
+       :date:message-id:mime-version:content-type:x-gm-message-state;\r
+       bh=XIVfDqkvQiwl6hpYlGTTItHZTCMS3k9GJKBfU1HDSL8=;\r
+       b=c6Fln6JSh4cnTj0aAaqyFsf1DDIIrnsOV+29RnM/OY8JimRqZXMfka16ORdateZrBo\r
+       hzzwGBhcJFR+p5TJp55Ufa4M9DJQU2ZTG8J2kjkFTSMbypbSLAuM2hEuE6MOciryca0z\r
+       aPUnQklk/LDXx+ElaQ/kKXpaYuWyOBzYuP+OaE39pMIGpexrfSJ+Lv3/yoSu5MdC9klz\r
+       Yrg/MsomPy5I2Px3x4/qU8Ckex3gZ+tODLGjlD/tmxrJgjnj4r9E7xmuZgHrXruwgsYZ\r
+       BZm+6O0hzVh/YMHBAJtl6T/NhMJstBmqY2owMD5vKL8ZznFkftS08HHXf8bqOp3UeWeH\r
+       ozVg==\r
+X-Received: by 10.152.3.201 with SMTP id e9mr3140404lae.12.1367526995757;\r
+       Thu, 02 May 2013 13:36:35 -0700 (PDT)\r
+Received: from localhost (dsl-hkibrasgw2-58c376-211.dhcp.inet.fi.\r
+       [88.195.118.211])\r
+       by mx.google.com with ESMTPSA id x9sm3231397lbi.15.2013.05.02.13.36.33\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Thu, 02 May 2013 13:36:34 -0700 (PDT)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>,\r
+       Vladimir Marek <Vladimir.Marek@Oracle.COM>\r
+Subject: Re: [PATCH 01/24] lib/message.cc: stale pointer bug\r
+In-Reply-To: <m238u5tg2f.fsf@guru.guru-group.fi>\r
+References: <1367444021-2757-1-git-send-email-Vladimir.Marek@oracle.com>\r
+       <m2sj25snsk.fsf@guru.guru-group.fi>\r
+       <20130502134530.GB23259@pub.cz.oracle.com>\r
+       <m238u5tg2f.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.15.2+70~g2eeb96a (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Thu, 02 May 2013 23:36:30 +0300\r
+Message-ID: <87mwsd3yr5.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Gm-Message-State:\r
+ ALoCoQnq5i7/18+ftMJtrhyvPF0upCKVUz9xL12dnavccf2T09o+AQsTVRMYW13wzt+hvclalzXe\r
+Cc: notmuch@notmuchmail.org, Vladimir Marek <vlmarek@volny.cz>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 02 May 2013 20:36:42 -0000\r
+\r
+On Thu, 02 May 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:\r
+> On Thu, May 02 2013, Vladimir Marek <Vladimir.Marek@Oracle.COM> wrote:\r
+>\r
+>>> >      int prefix_len = strlen (prefix);\r
+>>> > -    const char *term = NULL;\r
+>>> > +    std::string term;\r
+>>> >      char *value;\r
+>>> >  \r
+>>> >      i.skip_to (prefix);\r
+>>> >  \r
+>>> > -    if (i != end)\r
+>>> > -        term = (*i).c_str ();\r
+>>> > +    if (i == end)\r
+>>> > +        return NULL;\r
+>>> >  \r
+>>> > -    if (!term || strncmp (term, prefix, prefix_len))\r
+>>> > +    term = *i;\r
+>>> \r
+>>> ... hmm, a raii(?) solution above would be std::string term = *i;\r
+>>\r
+>> I'm not sure what's raii (I'm not very good at c++ ...), but I guess you\r
+>> mean to use 'std::string term = *i;' to avoid copy constructor. That\r
+>> surely is a good idea. Let me rework the patch!\r
+>\r
+> I am not that smart (i.e. avoid copy constructor it might be, I don't\r
+> know...) I am lousy in c++. I attempter to mean\r
+> http://en.wikipedia.org/wiki/Resource_Acquisition_Is_Initialization\r
+> in a sense that when variable is introduced it is also initialized\r
+> to useful value (so that no-one accidentally add code between introduction\r
+> and initialization). \r
+>  \r
+> Anyway, if you rework the patch then we can vote which version to\r
+> apply (yeah, sure >;)\r
+\r
+I already dropped needs-review from the latest version [1]. I'm curious\r
+about patches 2-24, let's not stall here. ;)\r
+\r
+Jani.\r
+\r
+\r
+[1] id:1367505102-12860-1-git-send-email-Vladimir.Marek@oracle.com\r