Re: [PATCH v2] emacs: show: change emacs interactive pipe message.

diff --git a/af/94b3977512694748946bd75898274c87ccb8c2 b/af/94b3977512694748946bd75898274c87ccb8c2
new file mode 100644 (file)
index 0000000..d884491
--- /dev/null
+++ b/af/94b3977512694748946bd75898274c87ccb8c2
@@ -0,0 +1,98 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A6FBB431FB6\r
+       for <notmuch@notmuchmail.org>; Sun,  9 Jun 2013 03:33:53 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id ke6D1T3TA8H4 for <notmuch@notmuchmail.org>;\r
+       Sun,  9 Jun 2013 03:33:44 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id BD741431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  9 Jun 2013 03:33:44 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 2DC0F100044;\r
+       Sun,  9 Jun 2013 13:33:42 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2] emacs: show: change emacs interactive pipe message.\r
+In-Reply-To: <1370767308-1636-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1369944667-22705-1-git-send-email-markwalters1009@gmail.com>\r
+       <1370767308-1636-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.15.2+172~ge989640 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 09 Jun 2013 13:33:41 +0300\r
+Message-ID: <m27gi3y3ne.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 09 Jun 2013 10:33:53 -0000\r
+\r
+On Sun, Jun 09 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> Previously the query string for piping a message to a command was\r
+> "Pipe message to command: " regardless of whether the function was\r
+> called with a prefix argument (which pipes all open messages to the\r
+> command). This patch modifies the `interactive' command to reflect\r
+> this.\r
+> ---\r
+> This has the whitespace fix Tomi mentioned but is otherwise unchanged.\r
+\r
+LGTM, my review comments in id:m2wqqftvu3.fsf@guru.guru-group.fi apply.\r
+\r
+> Best wishes\r
+\r
+Tomi\r
+\r
+\r
+>\r
+> Mark\r
+>\r
+>\r
+>  emacs/notmuch-show.el |    5 ++++-\r
+>  1 files changed, 4 insertions(+), 1 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 83bb9ad..d863f2b 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1702,7 +1702,10 @@ to stdout or stderr will appear in the *notmuch-pipe* buffer.\r
+>  When invoked with a prefix argument, the command will receive all\r
+>  open messages in the current thread (formatted as an mbox) rather\r
+>  than only the current message."\r
+> -  (interactive "P\nsPipe message to command: ")\r
+> +  (interactive (let ((query-string (if current-prefix-arg\r
+> +                                   "Pipe all open messages to command: "\r
+> +                                 "Pipe message to command: ")))\r
+> +             (list current-prefix-arg (read-string query-string))))\r
+>    (let (shell-command)\r
+>      (if entire-thread\r
+>      (setq shell-command\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r