Re: [PATCH] test: move nonexistant directory to something under notmuch's control.

diff --git a/79/b0fcffe2dd23e9b8e9b0186dad3d189aff27ba b/79/b0fcffe2dd23e9b8e9b0186dad3d189aff27ba
new file mode 100644 (file)
index 0000000..0b689ca
--- /dev/null
+++ b/79/b0fcffe2dd23e9b8e9b0186dad3d189aff27ba
@@ -0,0 +1,104 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id E91EA6DE1992\r
+ for <notmuch@notmuchmail.org>; Tue,  7 Apr 2015 05:30:52 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.179\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.179 tagged_above=-999 required=5 tests=[AWL=0.527, \r
+ SPF_NEUTRAL=0.652] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id kqDbAIRVdTgQ for <notmuch@notmuchmail.org>;\r
+ Tue,  7 Apr 2015 05:30:46 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 75ABC6DE198A\r
+ for <notmuch@notmuchmail.org>; Tue,  7 Apr 2015 05:30:46 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+ by guru.guru-group.fi (Postfix) with ESMTP id 7D11010019F;\r
+ Tue,  7 Apr 2015 15:30:20 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] test: move nonexistant directory to something under\r
+ notmuch's control.\r
+In-Reply-To: <1428408900-22839-1-git-send-email-david@tethera.net>\r
+References: <1428408900-22839-1-git-send-email-david@tethera.net>\r
+User-Agent: Notmuch/0.19+107~gab55bdb (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 07 Apr 2015 15:30:20 +0300\r
+Message-ID: <m2h9sst92b.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 07 Apr 2015 12:30:53 -0000\r
+\r
+On Tue, Apr 07 2015, David Bremner <david@tethera.net> wrote:\r
+\r
+> Apparently some systems actually have a directory called /nonexistent.\r
+> It's hard to fathom a good reason for that, but oh well. As long as we\r
+> don't create such a directory inside the notmuch source tree, the new\r
+> version should be more robust.\r
+\r
+2 things\r
+\r
+although it makes this diff bigger should all /nonexistent... paths be\r
+changed to ./nonexistent... -- it is a bit confusing having just this one\r
+(or should there be another patch which converts rest of those)\r
+\r
+Is 'nonexistant' there for a reason (as dictionaries find definitions for\r
+that) or is it misspelling of 'nonexistent'. If there is no reason I'd like\r
+to see it written 'nonexistent' uniformly :D\r
+\r
+\r
+Tomi\r
+\r
+\r
+> ---\r
+> This should (hopefully) fix the current failures on travis\r
+>  test/T560-lib-error.sh | 4 ++--\r
+>  1 file changed, 2 insertions(+), 2 deletions(-)\r
+>\r
+> diff --git a/test/T560-lib-error.sh b/test/T560-lib-error.sh\r
+> index 828a44b..57abb28 100755\r
+> --- a/test/T560-lib-error.sh\r
+> +++ b/test/T560-lib-error.sh\r
+> @@ -43,13 +43,13 @@ int main (int argc, char** argv)\r
+>  {\r
+>      notmuch_database_t *db;\r
+>      notmuch_status_t stat;\r
+> -    stat = notmuch_database_open ("/nonexistent/foo", 0, 0);\r
+> +    stat = notmuch_database_open ("./nonexistent/foo", 0, 0);\r
+>  }\r
+>  EOF\r
+>  cat <<'EOF' >EXPECTED\r
+>  == stdout ==\r
+>  == stderr ==\r
+> -Error opening database at /nonexistent/foo/.notmuch: No such file or directory\r
+> +Error opening database at ./nonexistent/foo/.notmuch: No such file or directory\r
+>  EOF\r
+>  test_expect_equal_file EXPECTED OUTPUT\r
+>  \r
+> -- \r
+> 2.1.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r