Re: [PATCH 4/4] emacs: Simplify and fix `notmuch-mua-prompt-for-sender'

diff --git a/cf/325de34521818e78e0773065418e169ccdb9cd b/cf/325de34521818e78e0773065418e169ccdb9cd
new file mode 100644 (file)
index 0000000..d7ac75f
--- /dev/null
+++ b/cf/325de34521818e78e0773065418e169ccdb9cd
@@ -0,0 +1,73 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5CD6F431FBD\r
+       for <notmuch@notmuchmail.org>; Sat, 22 Feb 2014 02:17:37 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 2w1GlIgtZV4S for <notmuch@notmuchmail.org>;\r
+       Sat, 22 Feb 2014 02:17:33 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7B296431FB6\r
+       for <notmuch@notmuchmail.org>; Sat, 22 Feb 2014 02:17:33 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 03EDF10005E;\r
+       Sat, 22 Feb 2014 12:17:25 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 4/4] emacs: Simplify and fix\r
+       `notmuch-mua-prompt-for-sender'\r
+In-Reply-To: <1392923797-17045-5-git-send-email-amdragon@mit.edu>\r
+References: <1392923797-17045-1-git-send-email-amdragon@mit.edu>\r
+       <1392923797-17045-5-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.17+94~g1b90823 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 22 Feb 2014 12:17:24 +0200\r
+Message-ID: <m28ut3cuyz.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: bjonnh-nm@bjonnh.net\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 22 Feb 2014 10:17:37 -0000\r
+\r
+On Thu, Feb 20 2014, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+This seris LGTM. I don't know about patch 4 as I have not used\r
+the features (hand-edited From: always...)  maybe I should...\r
+\r
+Tomi\r
+\r
+\r
+> This patch rewrites `notmuch-mua-prompt-for-sender' to simply prompt\r
+> for a full identity, where the list of identities is derived from\r
+> either notmuch-identities or the user's Notmuch configuration.\r
+>\r
+> The original code also did several strange things, like using `eval'\r
+> and specifying that this function was interactive.  As a side-effect,\r
+> this patch fixes these problems.  And it adds a docstring.\r
+> ---\r
+>  emacs/notmuch-mua.el | 33 +++++++++------------------------\r
+>  1 file changed, 9 insertions(+), 24 deletions(-)\r
+>\r
+\r