[PATCH v4 4/4] nmbug-status: Hardcode UTF-8 instead of using the user's locale

diff --git a/a2/7ef7ab83aa1686e4fe22d249676bb4ad80a5e3 b/a2/7ef7ab83aa1686e4fe22d249676bb4ad80a5e3
new file mode 100644 (file)
index 0000000..ad5c3db
--- /dev/null
+++ b/a2/7ef7ab83aa1686e4fe22d249676bb4ad80a5e3
@@ -0,0 +1,127 @@
+Return-Path: <wking@tremily.us>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C08A3431FBD\r
+       for <notmuch@notmuchmail.org>; Fri, 14 Feb 2014 08:50:21 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References"\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id XZtU8LgAnfeu for <notmuch@notmuchmail.org>;\r
+       Fri, 14 Feb 2014 08:50:14 -0800 (PST)\r
+Received: from qmta04.westchester.pa.mail.comcast.net\r
+       (qmta04.westchester.pa.mail.comcast.net [76.96.62.40])\r
+       by olra.theworths.org (Postfix) with ESMTP id 79F2C431FBC\r
+       for <notmuch@notmuchmail.org>; Fri, 14 Feb 2014 08:50:14 -0800 (PST)\r
+Received: from omta17.westchester.pa.mail.comcast.net ([76.96.62.89])\r
+       by qmta04.westchester.pa.mail.comcast.net with comcast\r
+       id SETK1n00A1vXlb854GqEZW; Fri, 14 Feb 2014 16:50:14 +0000\r
+Received: from odin.tremily.us ([24.18.63.50])\r
+       by omta17.westchester.pa.mail.comcast.net with comcast\r
+       id SGqD1n005152l3L3dGqDh0; Fri, 14 Feb 2014 16:50:14 +0000\r
+Received: from mjolnir.tremily.us (unknown [192.168.0.140])\r
+       by odin.tremily.us (Postfix) with ESMTPS id C18EC103A9A6;\r
+       Fri, 14 Feb 2014 08:50:12 -0800 (PST)\r
+Received: (nullmailer pid 18390 invoked by uid 1000);\r
+       Fri, 14 Feb 2014 16:48:57 -0000\r
+From: "W. Trevor King" <wking@tremily.us>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v4 4/4] nmbug-status: Hardcode UTF-8 instead of using the\r
+       user's locale\r
+Date: Fri, 14 Feb 2014 08:48:55 -0800\r
+Message-Id:\r
+ <2ccf8081e5195473199923f76e71cc33552b63df.1392395932.git.wking@tremily.us>\r
+X-Mailer: git-send-email 1.8.5.2.8.g0f6c0d1\r
+In-Reply-To: <cover.1392395932.git.wking@tremily.us>\r
+References: <cover.1392395932.git.wking@tremily.us>\r
+In-Reply-To: <cover.1392395932.git.wking@tremily.us>\r
+References: <cover.1392395932.git.wking@tremily.us>\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;\r
+       s=q20121106; t=1392396614;\r
+       bh=hZxSG2hNFjKlPLJssd6MNC3pRSCBUYBw9bx42O44jD0=;\r
+       h=Received:Received:Received:Received:From:To:Subject:Date:\r
+       Message-Id;\r
+       b=P4e8PcZIjcDuRxQMvIcp9AZ2PvYtWJ1vsA+AQ/gfXNkWbh1FIb9N8fVDLQvQuawQG\r
+       03tzjQ7ysYejbqjnW7071OofLz/IUa4ptMTffAna9v9dLDTrBBxeuo1V7EL57yEDZi\r
+       dGcl1b7N+QEokrZBYjMaKowlsdwAhDv3bwkOPNEmhv6w1UH/Yv2T9RV/rPVQMmrokf\r
+       N9sEnZzOg2h7pzxT09VjAmV6VxkBtDudjFs5NZovTikgEgRdSyj/RA5ln0w3443Rwq\r
+       uGVMIcQZddidm95dVm42bDC3A08mUAMwOb8dGZUJMro0MmgYdbfufEWsz48yFvxJRk\r
+       xVWAwvkKtBIgw==\r
+Cc: Tomi Ollila <tomi.ollila@iki.fi>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 14 Feb 2014 16:50:21 -0000\r
+\r
+David [1] and Tomi [2] both feel that the user's choice of LANG is not\r
+explicit enough to have such a strong effect on nmbug-status.  For\r
+example, cron jobs usually default to LANG=C, and that is going to\r
+give you ASCII output:\r
+\r
+  $ LANG=C python -c 'import locale; print(locale.getpreferredencoding())'\r
+  ANSI_X3.4-1968\r
+\r
+Trying to print Unicode author names (and other strings) in that\r
+encoding would crash nmbug-status with a UnicodeEncodeError.  To avoid\r
+that, this patch hardcodes UTF-8, which can handle generic Unicode,\r
+and is the preferred encoding (regardless of LANG settings) for\r
+everyone who has chimed in on the list so far.  I'd prefer trusting\r
+LANG, but in the absence of any users that prefer non-UTF-8 encodings\r
+I'm fine with this approach.\r
+\r
+While we could achieve the same effect on the output content by\r
+dropping the previous patch (nmbug-status: Encode output using the\r
+user's locale), Tomi also wanted UTF-8 hardcoded as the config-file\r
+encoding [2].  Keeping the output encoding patch and then adding this\r
+to hardcode both the config-file and output encodings at once seems\r
+the easiest route, now that fd29d3f (nmbug-status: Decode Popen output\r
+using the user's locale, 2014-02-10) has landed in master.\r
+\r
+[1]: id="877g8z4v4x.fsf@zancas.localnet"\r
+     http://article.gmane.org/gmane.mail.notmuch.general/17202\r
+[2]: id="m2vbwj79lu.fsf@guru.guru-group.fi"\r
+     http://article.gmane.org/gmane.mail.notmuch.general/17209\r
+---\r
+ devel/nmbug/nmbug-status | 3 +--\r
+ 1 file changed, 1 insertion(+), 2 deletions(-)\r
+\r
+diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status\r
+index c4532f1..ef7169a 100755\r
+--- a/devel/nmbug/nmbug-status\r
++++ b/devel/nmbug/nmbug-status\r
+@@ -13,7 +13,6 @@ import codecs\r
+ import collections\r
+ import datetime\r
+ import email.utils\r
+-import locale\r
+ try:  # Python 3\r
+     from urllib.parse import quote\r
+ except ImportError:  # Python 2\r
+@@ -27,7 +26,7 @@ import subprocess\r
+ import xml.sax.saxutils\r
+ \r
+ \r
+-_ENCODING = locale.getpreferredencoding() or sys.getdefaultencoding()\r
++_ENCODING = 'UTF-8'\r
+ _PAGES = {}\r
+ \r
+ \r
+-- \r
+1.8.5.2.8.g0f6c0d1\r
+\r