Unquoted message ID in notmuch-mutt-tag

diff --git a/46/7baab8fd62b9202e9a2f91611467b35c11c33d b/46/7baab8fd62b9202e9a2f91611467b35c11c33d
new file mode 100644 (file)
index 0000000..3caf2c0
--- /dev/null
+++ b/46/7baab8fd62b9202e9a2f91611467b35c11c33d
@@ -0,0 +1,80 @@
+Return-Path: <jason@milr.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 164E5431FBC\r
+       for <notmuch@notmuchmail.org>; Mon, 22 Jul 2013 17:52:29 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id nRdZh2hM1dKJ for <notmuch@notmuchmail.org>;\r
+       Mon, 22 Jul 2013 17:52:21 -0700 (PDT)\r
+X-Greylist: delayed 1155 seconds by postgrey-1.32 at olra;\r
+       Mon, 22 Jul 2013 17:52:20 PDT\r
+Received: from fed1rmfepi208.cox.net (fed1rmfepi208.cox.net [68.230.241.153])\r
+       by olra.theworths.org (Postfix) with ESMTP id C43A1431FB6\r
+       for <notmuch@notmuchmail.org>; Mon, 22 Jul 2013 17:52:20 -0700 (PDT)\r
+Received: from fed1rmimpo305 ([68.230.241.173]) by fed1rmfepo203.cox.net\r
+       (InterMail vM.8.01.05.09 201-2260-151-124-20120717) with ESMTP\r
+       id <20130723003304.BWSP3846.fed1rmfepo203.cox.net@fed1rmimpo305>\r
+       for <notmuch@notmuchmail.org>; Mon, 22 Jul 2013 20:33:04 -0400\r
+Received: from localhost ([70.191.80.19]) by fed1rmimpo305 with cox\r
+       id 3cZ31m00J0R0GNW01cZ3bs; Mon, 22 Jul 2013 20:33:03 -0400\r
+X-CT-Class: Clean\r
+X-CT-Score: 0.00\r
+X-CT-RefID: str=0001.0A020207.51EDCF3F.012C,ss=1,re=0.000,fgs=0\r
+X-CT-Spam: 0\r
+X-Authority-Analysis: v=2.0 cv=R/Dd76tX c=1 sm=1\r
+       a=8Pu+u8o12PWZCfupdeghHQ==:17 a=wom5GMh1gUkA:10 a=wOsrnI10qBsA:10\r
+       a=as2ii8JTC2oA:10 a=kj9zAlcOel0A:10 a=BswL-RFwAAAA:8 a=kM_2MJY8AAAA:8\r
+       a=-DOwLxJbGmkA:10 a=Am0YYMluCUEbXP6Kt-EA:9 a=CjuIK1q_8ugA:10\r
+       a=bqnDBv3PJxgA:10 a=NI3GwEGIxhIA:10 a=8Pu+u8o12PWZCfupdeghHQ==:117\r
+X-CM-Score: 0.00\r
+Authentication-Results: cox.net; auth=pass (CRAM-MD5)\r
+       smtp.auth=aidenn01@cox.net\r
+Date: Mon, 22 Jul 2013 17:33:03 -0700\r
+From: Jason Miller <jason@milr.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: Unquoted message ID in notmuch-mutt-tag\r
+Message-ID: <20130723003303.GA21463@home.jasonmmiller.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Mailman-Approved-At: Tue, 30 Jul 2013 02:14:53 -0700\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 23 Jul 2013 00:52:29 -0000\r
+\r
+Hi,\r
+\r
+Just started using notmuch along with notmuch-mutt.  I found a bug in\r
+notmuch-mutt where the message id is not shell-quoted in the tag_action.\r
+a simple one-line-fix is to shell-quote the result of get_message_id:\r
+\r
+@@ -150,7 +150,7 @@\r
+ }\r
+ \r
+ sub tag_action(@) {\r
+-    my $mid = get_message_id();\r
++    my $mid = shell_quote(get_message_id());\r
+ \r
+     system("notmuch tag "\r
+           . shell_quote(join(' ', @_))\r
+\r
+-Jason\r