Re: [PATCH] vim: simplify build

diff --git a/b3/66397afb182530f792265d9edf02df60d078a6 b/b3/66397afb182530f792265d9edf02df60d078a6
new file mode 100644 (file)
index 0000000..48dcdee
--- /dev/null
+++ b/b3/66397afb182530f792265d9edf02df60d078a6
@@ -0,0 +1,115 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 25B49431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 06:11:07 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id lj0AE7WL-Csf for <notmuch@notmuchmail.org>;\r
+       Wed, 18 Apr 2012 06:11:06 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7EC32431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Apr 2012 06:11:06 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 6786A68055; Wed, 18 Apr 2012 16:11:02 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] vim: simplify build\r
+In-Reply-To: <1334751115-7216-1-git-send-email-felipe.contreras@gmail.com>\r
+References: <1334751115-7216-1-git-send-email-felipe.contreras@gmail.com>\r
+User-Agent: Notmuch/0.12+113~gde05574 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 18 Apr 2012 16:11:02 +0300\r
+Message-ID: <m2ty0hxk0p.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 18 Apr 2012 13:11:07 -0000\r
+\r
+On Wed, Apr 18 2012, Felipe Contreras <felipe.contreras@gmail.com> wrote:\r
+\r
+> There should be no functional changes, except that you don't need to\r
+> make the directories before installing.\r
+>\r
+> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>\r
+> ---\r
+\r
+Hmm, Where is $(PWD) make variable documented; I found only $(CURDIR)\r
+anyway, te following test makefile works OK.\r
+\r
+all:\r
+        echo $(PWD)\r
+        echo $(CURDIR)\r
+\r
+(i.e. both echo the current directory)\r
+\r
+If this is not an issue, then LGTM.\r
+\r
+Tomi\r
+\r
+>  vim/Makefile |   19 +++++++++----------\r
+>  1 file changed, 9 insertions(+), 10 deletions(-)\r
+>\r
+> diff --git a/vim/Makefile b/vim/Makefile\r
+> index 89e18be..e7b7faa 100644\r
+> --- a/vim/Makefile\r
+> +++ b/vim/Makefile\r
+> @@ -1,11 +1,11 @@\r
+>  .PHONY: all help install link symlink\r
+>  \r
+> -FILES     = plugin/notmuch.vim \\r
+> -        $(wildcard syntax/notmuch-*.vim)\r
+> +files = plugin/notmuch.vim \\r
+> +    $(wildcard syntax/notmuch-*.vim)\r
+> +prefix = $(HOME)/.vim\r
+> +destdir = $(prefix)/plugin\r
+>  \r
+> -PREFIX    = $(shell ls -d ~/.vim/)\r
+> -\r
+> -OUT_FILES = $(FILES:%=${PREFIX}/%)\r
+> +INSTALL = install -D -m644\r
+>  \r
+>  all: help\r
+>  \r
+> @@ -16,9 +16,8 @@ help:\r
+>      @echo "    make install     - copy plugin scripts and syntax files to ~/.vim"\r
+>      @echo "    make symlink     - create symlinks in ~/.vim (useful for development)"\r
+>  \r
+> -install: ${OUT_FILES}\r
+> -link symlink:\r
+> -    ${MAKE} SYMLINK=1 install\r
+> +install:\r
+> +    @for x in $(files); do $(INSTALL) $(PWD)/$$x $(prefix)/$$x; done\r
+>  \r
+> -${OUT_FILES}: ${PREFIX}/%: %\r
+> -    $(if ${SYMLINK},ln -fs,cp) `pwd`/$< $@\r
+> +link symlink: INSTALL = ln -fs\r
+> +link symlink: install\r
+> -- \r
+> 1.7.10\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r