RE: [PATCH 5/5] Drop harmful reply buffer preparation

diff --git a/64/58d969077a53a3b32c5efd86ba17c860cea8f7 b/64/58d969077a53a3b32c5efd86ba17c860cea8f7
new file mode 100644 (file)
index 0000000..d3babcc
--- /dev/null
+++ b/64/58d969077a53a3b32c5efd86ba17c860cea8f7
@@ -0,0 +1,115 @@
+Return-Path: <felipe.contreras@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7A069431FAF\r
+       for <notmuch@notmuchmail.org>; Tue,  2 Apr 2013 12:53:00 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id M0mwgzWC5fpl for <notmuch@notmuchmail.org>;\r
+       Tue,  2 Apr 2013 12:53:00 -0700 (PDT)\r
+Received: from mail-ye0-f177.google.com (mail-ye0-f177.google.com\r
+       [209.85.213.177]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id E7ABD431FAE\r
+       for <notmuch@notmuchmail.org>; Tue,  2 Apr 2013 12:52:59 -0700 (PDT)\r
+Received: by mail-ye0-f177.google.com with SMTP id l14so123368yen.22\r
+       for <notmuch@notmuchmail.org>; Tue, 02 Apr 2013 12:52:59 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=x-received:date:from:to:cc:message-id:in-reply-to:references\r
+       :subject:mime-version:content-type:content-transfer-encoding;\r
+       bh=TEpx7c5/V04LuuhQCRorljhZxRivZtV/9s4zObmHDkA=;\r
+       b=pO6BqYpsGbIydnjEz+lOpBd04T1aKEE32F1/D9VUXEJN6Uzuli1IP7EV678pp+qIm1\r
+       re9va5CGC1UtfxV6gGmLSWe5vi34V3WbH8DIb4AywZh9iBuHTEGxXopb2MnBB0cskLQu\r
+       Mr2E2XP8aXzbufW4qzjLWsQZiYf89gxLHp7EUgygh9cqdxWO3fTtWXxqNexcA9x6EyrP\r
+       yRASU1uzv6WTM3AZNwS8TIIZ/J+AQKJ8wRB+N77stckeekDl9Q0SztHNtp2lRJs4oQp8\r
+       bcy03vlMgE9is779iaAp5nZiG4zDYILGBpkdpNh9lEQezps62UI1SEM4fws5u1crk/vG\r
+       E5MQ==\r
+X-Received: by 10.236.16.202 with SMTP id h50mr16621895yhh.39.1364932379469;\r
+       Tue, 02 Apr 2013 12:52:59 -0700 (PDT)\r
+Received: from localhost (187-163-100-70.static.axtel.net. [187.163.100.70])\r
+       by mx.google.com with ESMTPS id w69sm5170223yhe.4.2013.04.02.12.52.57\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Tue, 02 Apr 2013 12:52:58 -0700 (PDT)\r
+Date: Tue, 02 Apr 2013 13:46:25 -0600\r
+From: Felipe Contreras <felipe.contreras@gmail.com>\r
+To: "Kirill A. Shutemov" <kirill@shutemov.name>, \r
+       Felipe Contreras <felipe.contreras@gmail.com>\r
+Message-ID: <515b359189b29_146e1045e1093948@nysa.mail>\r
+In-Reply-To: <1359388340-27136-6-git-send-email-kirill@shutemov.name>\r
+References: <1359388340-27136-1-git-send-email-kirill@shutemov.name>\r
+       <1359388340-27136-6-git-send-email-kirill@shutemov.name>\r
+Subject: RE: [PATCH 5/5] Drop harmful reply buffer preparation\r
+Mime-Version: 1.0\r
+Content-Type: text/plain;\r
+ charset=utf-8\r
+Content-Transfer-Encoding: 7bit\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 02 Apr 2013 19:53:00 -0000\r
+\r
+Kirill A. Shutemov wrote:\r
+> From: "Kirill A. Shutemov" <kirill@shutemov.name>\r
+> \r
+> Inserting empty lines at the end of reply buffer and switching to insert\r
+> mode are not what user want on reply. It's only annoying if you try to\r
+> comment on patch.\r
+> \r
+> If a user really wants this kind of preparation it should be implemented\r
+> as an user-specific hook.\r
+\r
+Insert mode, maybe, but the empty lines don't hurt. See, with your patch I end up in:\r
+\r
+>                      part = orig.find_first_text\r
+>                      part.convert.each_line do |l|\r
+>                              body_lines << "> %s" % l.chomp\r
+> -- \r
+> 1.7.10.4             <- HERE\r
+> \r
+> -- \r
+\r
+I cannot type there, and in any case I have to remove those lines, so I end\r
+selecting the text upwards and remove them.\r
+\r
+With the current code:\r
+\r
+>                      part = orig.find_first_text\r
+>                      part.convert.each_line do |l|\r
+>                              body_lines << "> %s" % l.chomp\r
+> -- \r
+> 1.7.10.4\r
+> \r
+>                      <- HERE\r
+> \r
+> -- \r
+\r
+Not much of a difference, I still have to select the lines upwards and remove them.\r
+\r
+That is of course if you reply *inline*. You might want to reply to the whole\r
+thing without modifications, in which case the original behavior is more\r
+useful.\r
+\r
+I'm not strongly opposed to this, but I don't see why those extra lines would hurt.\r
+\r
+Cheers.\r
+\r
+-- \r
+Felipe Contreras\r