Re: [PATCH] contrib: pick: use notmuch-start-notmuch

diff --git a/7e/7b9af2f43043416a7f01674ee9f2eba4285f15 b/7e/7b9af2f43043416a7f01674ee9f2eba4285f15
new file mode 100644 (file)
index 0000000..a70af8f
--- /dev/null
+++ b/7e/7b9af2f43043416a7f01674ee9f2eba4285f15
@@ -0,0 +1,111 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1DE69431FD6\r
+       for <notmuch@notmuchmail.org>; Thu,  4 Jul 2013 00:38:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id cPPgODNus2mM for <notmuch@notmuchmail.org>;\r
+       Thu,  4 Jul 2013 00:38:39 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id BB25F431FBF\r
+       for <notmuch@notmuchmail.org>; Thu,  4 Jul 2013 00:38:39 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id A737B100051;\r
+       Thu,  4 Jul 2013 10:38:33 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] contrib: pick: use notmuch-start-notmuch\r
+In-Reply-To: <1372921788-16042-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1372921788-16042-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.15.2+193~g7350bd4 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 04 Jul 2013 10:38:33 +0300\r
+Message-ID: <m2zju2lqpy.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 04 Jul 2013 07:38:48 -0000\r
+\r
+On Thu, Jul 04 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> This uses the new notmuch-start-notmuch function which should give\r
+> better handling of stderr and errors generally.\r
+> ---\r
+>\r
+> Hi\r
+>\r
+> This converts pick to Austin's new async error handling code (see\r
+> commit 08fde50bf3a4c54f6413aff4052e0d84392463f9). That code separates\r
+> stderr from stdout and makes sure that appropriate messages are\r
+> displayed to the user.\r
+>\r
+> I think this is simple enough and beneficial enough to go in for 0.16\r
+> (so I will tag it 0.16). Of course it only affects notmuch-pick so\r
+> is relatively safe.\r
+\r
+FWIW the code LGTM. Do the pick tests use this and do those pass ?\r
+\r
+Tomi\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+>\r
+>  contrib/notmuch-pick/notmuch-pick.el |    7 +++----\r
+>  1 files changed, 3 insertions(+), 4 deletions(-)\r
+>\r
+> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el\r
+> index fbd7c0b..7f5f729 100644\r
+> --- a/contrib/notmuch-pick/notmuch-pick.el\r
+> +++ b/contrib/notmuch-pick/notmuch-pick.el\r
+> @@ -817,16 +817,15 @@ Complete list of currently available key bindings:\r
+>      (if (equal (car (process-lines notmuch-command "count" search-args)) "0")\r
+>      (setq search-args basic-query))\r
+>      (if notmuch-pick-asynchronous-parser\r
+> -    (let ((proc (start-process\r
+> -                 "notmuch-pick" buffer\r
+> -                 notmuch-command "show" "--body=false" "--format=sexp"\r
+> +    (let ((proc (notmuch-start-notmuch\r
+> +                 "notmuch-pick" buffer #'notmuch-pick-process-sentinel\r
+> +                 "show" "--body=false" "--format=sexp"\r
+>                   message-arg search-args))\r
+>            ;; Use a scratch buffer to accumulate partial output.\r
+>                ;; This buffer will be killed by the sentinel, which\r
+>                ;; should be called no matter how the process dies.\r
+>                (parse-buf (generate-new-buffer " *notmuch pick parse*")))\r
+>            (process-put proc 'parse-buf parse-buf)\r
+> -      (set-process-sentinel proc 'notmuch-pick-process-sentinel)\r
+>        (set-process-filter proc 'notmuch-pick-process-filter)\r
+>        (set-process-query-on-exit-flag proc nil))\r
+>        (progn\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r