Re: [RFC 3/5] cli: support shell globbing patterns in new.ignore

diff --git a/a1/d6785622c7b346e84a205dcaf340e7f0b241e5 b/a1/d6785622c7b346e84a205dcaf340e7f0b241e5
new file mode 100644 (file)
index 0000000..40a70e9
--- /dev/null
+++ b/a1/d6785622c7b346e84a205dcaf340e7f0b241e5
@@ -0,0 +1,68 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 887E16DE02BF\r
+ for <notmuch@notmuchmail.org>; Sat,  9 Apr 2016 17:37:46 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.019\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.019 tagged_above=-999 required=5\r
+ tests=[AWL=-0.008, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id kwxFBeizl3jy for <notmuch@notmuchmail.org>;\r
+ Sat,  9 Apr 2016 17:37:38 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 30DB86DE00BD\r
+ for <notmuch@notmuchmail.org>; Sat,  9 Apr 2016 17:37:38 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1ap3Nq-0001Sb-0w; Sat, 09 Apr 2016 20:37:46 -0400\r
+Received: (nullmailer pid 14188 invoked by uid 1000);\r
+ Sun, 10 Apr 2016 00:37:34 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [RFC 3/5] cli: support shell globbing patterns in new.ignore\r
+In-Reply-To:\r
+ <51db8c12299cb1765d346fa2c93c6c95abb92613.1446579858.git.jani@nikula.org>\r
+References: <cover.1446579858.git.jani@nikula.org>\r
+ <51db8c12299cb1765d346fa2c93c6c95abb92613.1446579858.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.21+109~g9d467d4 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 09 Apr 2016 21:37:34 -0300\r
+Message-ID: <871t6efgdt.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 10 Apr 2016 00:37:46 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> Keep the existing strcmp on the basename for backwards compatibility,\r
+> and additionally use the new.ignore entries as fnmatch(3) patterns on\r
+> the absolute filename. Note that it's not enough to add e.g. "foo*bar"\r
+> to the list; you will need to do "*/foo*bar" to match the path also.\r
+\r
+I guess when you say absolute file name, you mean the obvious thing, not\r
+relative to the root of the notmuch maildir. It seems like it would be\r
+quite useful to e.g. ignore directory foo at the top level of the\r
+maildir, but not anywhere else, by specifying /foo as an ignore\r
+pattern. I guess this would just require stripping the maildir root off\r
+the front of the path before doing the fnmatch? That's not currently\r
+part of the add_files_state_t, but it could be.\r
+\r
+d\r