Re: [PATCH v2 00/10] add insert --must-index option

diff --git a/48/57b8a7364616591e50d7ccd9d8c368c786aa38 b/48/57b8a7364616591e50d7ccd9d8c368c786aa38
new file mode 100644 (file)
index 0000000..cb383c0
--- /dev/null
+++ b/48/57b8a7364616591e50d7ccd9d8c368c786aa38
@@ -0,0 +1,113 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 08B6A431FC2\r
+       for <notmuch@notmuchmail.org>; Tue,  6 May 2014 14:00:36 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id xq+4SiQWoePJ for <notmuch@notmuchmail.org>;\r
+       Tue,  6 May 2014 14:00:28 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1F7D7431FAF\r
+       for <notmuch@notmuchmail.org>; Tue,  6 May 2014 14:00:28 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id B5A761000E5;\r
+       Wed,  7 May 2014 00:00:23 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Peter Wang <novalazy@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 00/10] add insert --must-index option\r
+In-Reply-To: <1397653165-15620-1-git-send-email-novalazy@gmail.com>\r
+References: <1397653165-15620-1-git-send-email-novalazy@gmail.com>\r
+User-Agent: Notmuch/0.18+12~gbfbd199 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Wed, 07 May 2014 00:00:23 +0300\r
+Message-ID: <m2lhuewrko.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 06 May 2014 21:00:36 -0000\r
+\r
+On Wed, Apr 16 2014, Peter Wang <novalazy@gmail.com> wrote:\r
+\r
+> Follow up to id:1374365254-13227-1-git-send-email-novalazy@gmail.com\r
+> The main changes are to take into account failures during\r
+> tagging and flushing of the database.\r
+>\r
+> I took Jani's patch id:1390152046-6509-1-git-send-email-jani@nikula.org\r
+> without modification.\r
+>\r
+> The soname bump is included in case it is required.\r
+\r
+I guess it is -- then changing in that file is not enough, lib/notmuch.h\r
+needs to have the same change.\r
+\r
+But, would a MINOR value update work -- anyone who needs only 3.1.0\r
+could also work with 3.2.0...\r
+\r
+If MINOR update were sufficient then we would not need to add\r
+api changes that supports logging (etc.) to this conversation...\r
+\r
+... but anyone interested these changes should also take a look\r
+of the actual changes... :D\r
+\r
+Tomi\r
+\r
+> The python/go/ruby changes are untested.\r
+\r
+\r
+\r
+>\r
+>\r
+> Jani Nikula (1):\r
+>   lib: add return status to database close and destroy\r
+>\r
+> Peter Wang (9):\r
+>   lib: bump soname\r
+>   python: handle return status of database close and destroy\r
+>   go: add return status to database close method\r
+>   ruby: handle return status of database close\r
+>   cli: refactor insert\r
+>   cli: indicate insert failure mode in exit status\r
+>   cli: add insert --must-index option\r
+>   test: test insert --must-index\r
+>   man: update insert documentation\r
+>\r
+>  bindings/go/src/notmuch/notmuch.go  |   4 +-\r
+>  bindings/python/notmuch/database.py |  12 ++--\r
+>  bindings/ruby/database.c            |   4 +-\r
+>  doc/man1/notmuch-insert.rst         |  24 +++++--\r
+>  lib/Makefile.local                  |   2 +-\r
+>  lib/database.cc                     |  30 ++++++--\r
+>  lib/notmuch.h                       |  15 +++-\r
+>  notmuch-insert.c                    | 134 +++++++++++++++++++++---------------\r
+>  test/T070-insert.sh                 |  32 +++++++--\r
+>  9 files changed, 176 insertions(+), 81 deletions(-)\r
+>\r
+> -- \r
+> 1.8.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r