--- /dev/null
+Return-Path: <jinwoo68@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 2B216431FAE\r
+ for <notmuch@notmuchmail.org>; Fri, 30 Jan 2015 16:10:21 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.639\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.639 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ DNS_FROM_AHBL_RHSBL=2.438, FREEMAIL_ENVFROM_END_DIGIT=1,\r
+ FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id xzD+f9eHoth8 for <notmuch@notmuchmail.org>;\r
+ Fri, 30 Jan 2015 16:10:18 -0800 (PST)\r
+Received: from mail-ie0-f170.google.com (mail-ie0-f170.google.com\r
+ [209.85.223.170]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 3CFE8431FC4\r
+ for <notmuch@notmuchmail.org>; Fri, 30 Jan 2015 16:10:18 -0800 (PST)\r
+Received: by mail-ie0-f170.google.com with SMTP id y20so7087526ier.1\r
+ for <notmuch@notmuchmail.org>; Fri, 30 Jan 2015 16:10:15 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type;\r
+ bh=lkBbgu9UR/07YPbe6Kh2SYksFFtiYb7o8rb4pDDfFv0=;\r
+ b=0FnIW7BFnSJdcT5oec6Se3uVi9r6/xtq3nL7qtwtbXU4G//zJwd9998uPSwIaUrm45\r
+ elZHN6hWg50kmpSHUT7HR14PR+tPPgh0IHEnjnSU5AjEY96g9AWUa28xx891kkws9rNp\r
+ NkaaPLjxXfJLMxm1E9k0F69NWs0ePbBjoNN+b7aFw9Gw6OqZb+g+3yWlrJoG7UO7ajwY\r
+ V5a6I1XTwrPNc10PKfUXWykPtoUDtAf5LNWzvJUWcwX9m54ymuyhGoBDoaaa35lX6Mf0\r
+ Nxz2x8fFnb1rpx5vDMEMuemGRsEexJsS6l8+JAQs7O+sn04g0Fl57XfqL3dlvZxKLUQq\r
+ jY7A==\r
+X-Received: by 10.50.111.168 with SMTP id ij8mr95774igb.43.1422663015695;\r
+ Fri, 30 Jan 2015 16:10:15 -0800 (PST)\r
+Received: from localhost ([2620:0:1000:407c:4567:58c3:e7ba:87a3])\r
+ by mx.google.com with ESMTPSA id qr1sm2024572igb.18.2015.01.30.16.10.14\r
+ for <notmuch@notmuchmail.org>\r
+ (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+ Fri, 30 Jan 2015 16:10:15 -0800 (PST)\r
+From: Jinwoo Lee <jinwoo68@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Add a defcustom that specifies regexp for blocked\r
+ remote images.\r
+In-Reply-To: <1422567352-32647-1-git-send-email-jinwoo68@gmail.com>\r
+References: <1422567352-32647-1-git-send-email-jinwoo68@gmail.com>\r
+User-Agent: Notmuch/0.18.1 (http://notmuchmail.org) Emacs/24.4.1\r
+ (x86_64-apple-darwin13.2.0)\r
+Date: Fri, 30 Jan 2015 16:10:12 -0800\r
+Message-ID: <yq65fvaru7x7.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 31 Jan 2015 00:10:21 -0000\r
+\r
+Can someone take a look please?\r
+\r
+On Thu, Jan 29, 2015 at 01:35 PM, Jinwoo Lee <jinwoo68@gmail.com> wrote:\r
+> It's default value is ".", meaning all remote images will be blocked\r
+> by default.\r
+>\r
+> ---\r
+> This time setting gnus-blocked-images from the correct place.\r
+> ---\r
+> emacs/notmuch-show.el | 23 ++++++++++++++++++-----\r
+> 1 file changed, 18 insertions(+), 5 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 66350d4..6f38e0c 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -136,6 +136,11 @@ indentation."\r
+> :type 'boolean\r
+> :group 'notmuch-show)\r
+> \r
+> +(defcustom notmuch-show-text/html-blocked-images "."\r
+> + "Remote images that have URLs matching this regexp will be blocked."\r
+> + :type '(choice (const nil) regexp)\r
+> + :group 'notmuch-show)\r
+> +\r
+> (defvar notmuch-show-thread-id nil)\r
+> (make-variable-buffer-local 'notmuch-show-thread-id)\r
+> (put 'notmuch-show-thread-id 'permanent-local t)\r
+> @@ -798,16 +803,24 @@ will return nil if the CID is unknown or cannot be retrieved."\r
+> ;; URL-decode it (see RFC 2392).\r
+> (let ((cid (url-unhex-string url)))\r
+> (first (notmuch-show--get-cid-content cid)))))\r
+> - ;; Block all external images to prevent privacy leaks and\r
+> - ;; potential attacks. FIXME: If we block an image, offer a\r
+> - ;; button to load external images.\r
+> - (shr-blocked-images "."))\r
+> + ;; By default, block all external images to prevent privacy\r
+> + ;; leaks and potential attacks. FIXME: If we block an image,\r
+> + ;; offer a button to load external images.\r
+> + (shr-blocked-images notmuch-show-text/html-blocked-images))\r
+> (shr-insert-document dom)\r
+> t))\r
+> \r
+> (defun notmuch-show-insert-part-*/* (msg part content-type nth depth button)\r
+> ;; This handler _must_ succeed - it is the handler of last resort.\r
+> - (notmuch-mm-display-part-inline msg part content-type notmuch-show-process-crypto)\r
+> +\r
+> + ;; By default, block all external images to prevent privacy leaks\r
+> + ;; and potential attacks. FIXME: If we block an image, offer a\r
+> + ;; button to load external images.\r
+> + ;; Note that GNUS-BLOCKED-IMAGES is effective only when\r
+> + ;; MM-TEXT-HTML-RENDERER is 'gnus-w3m.\r
+> + (let ((gnus-blocked-images notmuch-show-text/html-blocked-images))\r
+> + (notmuch-mm-display-part-inline msg part content-type\r
+> + notmuch-show-process-crypto))\r
+> t)\r
+> \r
+> ;; Functions for determining how to handle MIME parts.\r
+> -- \r
+> 2.2.2\r
projects / notmuch-archives.git / commitdiff