Re: [PATCH] python/thread: always return a string in get_subject/authors

diff --git a/82/6bc6c0f870ef4a36cfb579e9448c4461edae83 b/82/6bc6c0f870ef4a36cfb579e9448c4461edae83
new file mode 100644 (file)
index 0000000..fe4723a
--- /dev/null
+++ b/82/6bc6c0f870ef4a36cfb579e9448c4461edae83
@@ -0,0 +1,118 @@
+Return-Path: <dkg@fifthhorseman.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id BDE62429E2C\r
+       for <notmuch@notmuchmail.org>; Mon,  9 May 2011 18:18:47 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id hhjV94nVRM5L for <notmuch@notmuchmail.org>;\r
+       Mon,  9 May 2011 18:18:47 -0700 (PDT)\r
+Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108])\r
+       by olra.theworths.org (Postfix) with ESMTP id 52464429E2B\r
+       for <notmuch@notmuchmail.org>; Mon,  9 May 2011 18:18:47 -0700 (PDT)\r
+Received: from [192.168.13.75] (lair.fifthhorseman.net [216.254.116.241])\r
+       by che.mayfirst.org (Postfix) with ESMTPSA id 5171EF970\r
+       for <notmuch@notmuchmail.org>; Mon,  9 May 2011 21:18:45 -0400 (EDT)\r
+Message-ID: <4DC8926E.9070209@fifthhorseman.net>\r
+Date: Mon, 09 May 2011 21:18:38 -0400\r
+From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>\r
+User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;\r
+       rv:1.9.2.15) Gecko/20110402 Icedove/3.1.9\r
+MIME-Version: 1.0\r
+To: notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] python/thread: always return a string\r
+       in      get_subject/authors\r
+References: <1304924794-20380-1-git-send-email-anton@khirnov.net>\r
+       <87bozcvzdy.fsf@zancas.localnet>        <87zkmv5pz6.fsf@SSpaeth.de>\r
+In-Reply-To: <87zkmv5pz6.fsf@SSpaeth.de>\r
+X-Enigmail-Version: 1.1.2\r
+Content-Type: multipart/signed; micalg=pgp-sha512;\r
+       protocol="application/pgp-signature";\r
+       boundary="------------enig486932FB058B78023E8CC1D9"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+Reply-To: notmuch <notmuch@notmuchmail.org>\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 10 May 2011 01:18:47 -0000\r
+\r
+This is an OpenPGP/MIME signed message (RFC 2440 and 3156)\r
+--------------enig486932FB058B78023E8CC1D9\r
+Content-Type: text/plain; charset=UTF-8\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On 05/09/2011 09:00 PM, Sebastian Spaeth wrote:\r
+> On Mon, 09 May 2011 09:20:41 -0300, David Bremner <david@tethera.net> w=\r
+rote:\r
+>> On Mon,  9 May 2011 09:06:34 +0200, Anton Khirnov <anton@khirnov.net> =\r
+wrote:\r
+>>> Now None is returned when those don't exist, which is inconvenient to=\r
+\r
+>>> deal with.\r
+>>\r
+>> I'm not using the python bindings, but from a philosophical point of\r
+>> view, this change makes me a bit uncomfortable since it apparently\r
+>> merges two cases together, and makes an error (no Subject)\r
+>> indistinguishable from an odd situation (Subject of empty string).\r
+>> Or am I missing something here?\r
+>=20\r
+> This change makes me a bit uncomfortable too. 3 Reasons:\r
+>=20\r
+> - I believe users should be able to distinguish the case when someone\r
+>   uses an empty subject, and when someone doesn't specify a subject at\r
+>   all.\r
+\r
+I'm going to "me too!" this sentiment as well.  Please do *not* conflate\r
+no-subject with subject-is-empty-string.\r
+\r
+If we leave them distinct, the caller is free to conflate them if they\r
+want.  But if we conflate the two states first, there's no way for the\r
+caller to differentiate between the two if they want to.\r
+\r
+Thanks,\r
+\r
+       --dkg\r
+\r
+\r
+--------------enig486932FB058B78023E8CC1D9\r
+Content-Type: application/pgp-signature; name="signature.asc"\r
+Content-Description: OpenPGP digital signature\r
+Content-Disposition: attachment; filename="signature.asc"\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/\r
+\r
+iQJ8BAEBCgBmBQJNyJJ0XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w\r
+ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQwRUU1QkU5NzkyODJEODBCOUY3NTQwRjFD\r
+Q0QyRUQ5NEQyMTczOUU5AAoJEMzS7ZTSFznp70QQAJGZNLVb0Rmpuy82x1sefsWk\r
+5GmP5mzAJtvGIJD02H5G+TOewX2XT9/FVa5lGp2CS9TKHgdkB35fFr/e4YTCU522\r
+adkcrXDIapnP398u3kbnpX7kaUbJt63reNObpXQK1j2+jJCYo67COR2NouMYi42w\r
+7zr0NLybLe8zPgFfD0Fa9ntuwC1pRgcrwKO/Or+L6lpVWepEhUNpd3Xz2Q8Hv6ER\r
+eOg+WCQY30xG0ZtygNlLqyImx5Fzzcw3xLyhY7eo79EdgowGP+oSPh9ZzPOJO78f\r
+gqifX2zEDIutkurxTq3y85B5pgqAaPNt0lzWN6aH3cPuCmGQ2oZQRYNx3tEBw4Mf\r
+pqasCaPbh9B5sYt/VtHkKDfu8RAe1DAic7EVwYPei4suN0XMXHQSKzghpm8HgdyP\r
+TMp58O47qb/eUcRwcLPz24bt7V9Hc62wOXeVZWkFhqpibTKHDIr2ib85ASYgLmNt\r
+XmURRn6y5iFbAQ4WltF8sq0Eq0GX+i/rktmqn9Sw1RrhXa9SGCMZN0XldxLY+A7q\r
+OBzFoSAnBBUM4KUa1Yb5NVZSupNloC4O5zr53jid+2Y1cidQgfjkRZyAZppNxQTl\r
+i+ch45k0qgQfISDazkHTNkmabPqqmSWEKZZWoetCy9czjaggG48vblljfKhoRlez\r
+4VbEdalQVWE3xy9DgdqG\r
+=KTDE\r
+-----END PGP SIGNATURE-----\r
+\r
+--------------enig486932FB058B78023E8CC1D9--\r