Re: [PATCH v3 02/13] util: Const version of strtok_len
authorDavid Bremner <david@tethera.net>
Wed, 6 Aug 2014 13:43:33 +0000 (10:43 +2100)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:04:07 +0000 (10:04 -0800)
44/0210a7935e86fc63a1a39b8ac039ba3846b71b [new file with mode: 0644]

diff --git a/44/0210a7935e86fc63a1a39b8ac039ba3846b71b b/44/0210a7935e86fc63a1a39b8ac039ba3846b71b
new file mode 100644 (file)
index 0000000..56f2313
--- /dev/null
@@ -0,0 +1,64 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D1B0D431FAF\r
+       for <notmuch@notmuchmail.org>; Wed,  6 Aug 2014 06:43:43 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id a9bFl91TbwMF for <notmuch@notmuchmail.org>;\r
+       Wed,  6 Aug 2014 06:43:39 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 26B0F431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  6 Aug 2014 06:43:39 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XF1VC-0000EP-7s; Wed, 06 Aug 2014 10:43:38 -0300\r
+Received: (nullmailer pid 11391 invoked by uid 1000); Wed, 06 Aug 2014\r
+       13:43:33 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 02/13] util: Const version of strtok_len\r
+In-Reply-To: <1406859003-11561-3-git-send-email-amdragon@mit.edu>\r
+References: <1406859003-11561-1-git-send-email-amdragon@mit.edu>\r
+       <1406859003-11561-3-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.18.1+62~g0c12920 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 06 Aug 2014 10:43:33 -0300\r
+Message-ID: <87egwtd98a.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 06 Aug 2014 13:43:44 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+\r
+> Because of limitations in the C type system, we can't a strtok_len\r
+> that can work on both const string and non-const strings.  The C\r
+> library solves this by taking a const char* and returning a char*\r
+> in functions like this (e.g., strchr), but that's not const-safe.\r
+> Solve it by introducing strtok_len_c, a version of strtok_len for\r
+> const strings.\r
+\r
+pushed the first two patches in the series\r
+\r
+d\r