Re: [PATCH] Free the results of scandir()
authorTomi Ollila <tomi.ollila@iki.fi>
Tue, 7 Feb 2012 10:30:12 +0000 (12:30 +0200)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:44:15 +0000 (09:44 -0800)
40/8fd336fe53a12548cd66016f556cb70767eabf [new file with mode: 0644]

diff --git a/40/8fd336fe53a12548cd66016f556cb70767eabf b/40/8fd336fe53a12548cd66016f556cb70767eabf
new file mode 100644 (file)
index 0000000..d27e8e8
--- /dev/null
@@ -0,0 +1,82 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 44DB6431FB6\r
+       for <notmuch@notmuchmail.org>; Tue,  7 Feb 2012 02:30:19 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.01 tagged_above=-999 required=5\r
+       tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id oA+Z4U1gZX8w for <notmuch@notmuchmail.org>;\r
+       Tue,  7 Feb 2012 02:30:18 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7DA50431FAE\r
+       for <notmuch@notmuchmail.org>; Tue,  7 Feb 2012 02:30:18 -0800 (PST)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 5487268055; Tue,  7 Feb 2012 12:30:17 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Ethan Glasser-Camp <glasse@cs.rpi.edu>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] Free the results of scandir()\r
+In-Reply-To: <1328609103-7870-1-git-send-email-glasse@cs.rpi.edu>\r
+References: <1328609103-7870-1-git-send-email-glasse@cs.rpi.edu>\r
+User-Agent: Notmuch/0.11.1+164~g6619341 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 07 Feb 2012 12:30:12 +0200\r
+Message-ID: <m239an6imj.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+Cc: Ethan Glasser-Camp <ethan@betacantrips.com>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 07 Feb 2012 10:30:19 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Tue,  7 Feb 2012 05:05:03 -0500, Ethan Glasser-Camp <glasse@cs.rpi.edu> =\r
+wrote:\r
+> From: Ethan Glasser-Camp <ethan@betacantrips.com>\r
+>=20\r
+> scandir() returns "strings allocated via malloc(3)" which are then\r
+> "collected in array namelist which is allocated via\r
+> malloc(3)". Currently we just free the array namelist. Instead, free\r
+> all the entries of namelist, and then free namelist.\r
+>=20\r
+> entry only points to elements of namelist, so we don't free it\r
+> separately.\r
+> ---\r
+\r
++1\r
+\r
+Tomi\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.5 (GNU/Linux)\r
+\r
+iD8DBQFPMP05oEBNrhe2D3URAtIiAJsH3W1dFLa7XkPHOJa0VSBgASz4GQCgmHAo\r
+SV1oWmyyaPivI+D9cS2+Sik=\r
+=K9a/\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r