Re: [PATCH] lib: Simplify close and codify aborting atomic section

diff --git a/dd/c8e9a1025f196e79262b81f04cf1c8a6bf2b67 b/dd/c8e9a1025f196e79262b81f04cf1c8a6bf2b67
new file mode 100644 (file)
index 0000000..d92e4e6
--- /dev/null
+++ b/dd/c8e9a1025f196e79262b81f04cf1c8a6bf2b67
@@ -0,0 +1,81 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0E48B431FBD\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Sep 2014 11:09:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id MHp51RKLrlpb for <notmuch@notmuchmail.org>;\r
+       Wed, 24 Sep 2014 11:09:40 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 3893B431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 24 Sep 2014 11:09:40 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XWr0P-0001WY-1m; Wed, 24 Sep 2014 15:09:33 -0300\r
+Received: (nullmailer pid 12507 invoked by uid 1000); Wed, 24 Sep 2014\r
+       18:09:27 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: "W. Trevor King" <wking@tremily.us>, Austin Clements <amdragon@mit.edu>\r
+Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section\r
+In-Reply-To: <20140922190022.GO20827@odin.tremily.us>\r
+References: <1411400615-20934-1-git-send-email-amdragon@mit.edu>\r
+       <20140922165954.GI20827@odin.tremily.us>\r
+       <20140922185050.GB7970@csail.mit.edu>\r
+       <20140922190022.GO20827@odin.tremily.us>\r
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 24 Sep 2014 20:09:27 +0200\r
+Message-ID: <87iokc28mg.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 24 Sep 2014 18:09:48 -0000\r
+\r
+"W. Trevor King" <wking@tremily.us> writes:\r
+\r
+\r
+> Ah, I thought the implicit flush/commit was just in our code.  Since\r
+> it's also in the underlying Xapian close, then this patch looks pretty\r
+> good to me.  I'd mention Xapian's explicit close in the notmuch.\r
+h\r
+> message.  Xapain's docs say [1]:\r
+>\r
+>   For a WritableDatabase, if a transaction is active it will be\r
+>   aborted, while if no transaction is active commit() will be\r
+>   implicitly called.\r
+\r
+I'm not sure what you're asking for here by "explicit close". Isn't what\r
+you quote a restatement of \r
+\r
++ * If the caller is currently in an atomic section (there was a\r
++ * notmuch_database_begin_atomic without a matching\r
++ * notmuch_database_end_atomic), this will abort the atomic\r
+section,\r
++ * discarding any modifications made in the atomic section.\r
+\r
+in terms of underyling Xapian mechanics?\r
+\r
+\r
+P.S. Other than whatever this doc question is, the patch looks ok to me.\r