Re: [PATCH] emacs: Compute build dependencies to fix byte compile issues

diff --git a/9d/5c120550c0c64d125bdb1193274a8821b4618e b/9d/5c120550c0c64d125bdb1193274a8821b4618e
new file mode 100644 (file)
index 0000000..aa7e263
--- /dev/null
+++ b/9d/5c120550c0c64d125bdb1193274a8821b4618e
@@ -0,0 +1,84 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 0162D431FBC\r
+       for <notmuch@notmuchmail.org>; Sun, 19 May 2013 04:15:51 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 8F1BfQGP+H03 for <notmuch@notmuchmail.org>;\r
+       Sun, 19 May 2013 04:15:44 -0700 (PDT)\r
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id DDBFD431FB6\r
+       for <notmuch@notmuchmail.org>; Sun, 19 May 2013 04:15:43 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r4JBFeIt015376;\r
+       Sun, 19 May 2013 08:15:40 -0300\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1Ue1aW-0002xW-1r; Sun, 19 May 2013 08:15:40 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1Ue1aQ-00068o-EC; Sun, 19 May 2013 08:15:34 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: Compute build dependencies to fix byte compile\r
+       issues\r
+In-Reply-To: <1368821611-24110-1-git-send-email-amdragon@mit.edu>\r
+References: <1368821611-24110-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.15.2+84~g12d5e4e (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 19 May 2013 08:15:33 -0300\r
+Message-ID: <87y5bbjk4q.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 19 May 2013 11:15:52 -0000\r
+\r
+Austin Clements <amdragon@MIT.EDU> writes:\r
+>\r
+> This patch addresses these problems by computing make dependency rules\r
+> from the (require 'x) forms in the Elisp source files, which we inject\r
+> into make's dependency database.\r
+\r
+this seems to work as advertised.\r
+\r
+> +;;\r
+> +;; Copyright =C2=A9 Austin Clements\r
+\r
+I guess you need a copyright year?\r
+\r
+> +        ;; Is it a (require 'x) form?\r
+> +        (when (and (listp form) (=3D (length form) 2)\r
+> +                   (eq (car form) 'require)\r
+> +                   (listp (cadr form)) (=3D (length (cadr form)) 2)\r
+> +                   (eq (car (cadr form)) 'quote)\r
+> +                   (symbolp (cadr (cadr form))))\r
+\r
+This might be a corner case, but formally can't the argument to require\r
+be a variable or even a function call? Maybe this never happens in\r
+practice.\r