repoman: check more helper calls for $D, $ED...
authorZac Medico <zmedico@gentoo.org>
Tue, 9 Aug 2011 06:44:17 +0000 (23:44 -0700)
committerZac Medico <zmedico@gentoo.org>
Tue, 9 Aug 2011 06:44:17 +0000 (23:44 -0700)
This adds docinto, docompress, fowners and fperms to the
variable.usedwithhelpers check. Notably absent is dosed since that
supports mixed input. This will fix bug #377303.

pym/repoman/checks.py

index e7472df721d196488d90ddf31de9f3c5329e6a3e..bff4b1fbf5e80e540dc5c4bca439cefe03882aa3 100644 (file)
@@ -341,7 +341,7 @@ class NoOffsetWithHelpers(LineCheck):
        repoman_check_name = 'variable.usedwithhelpers'
        # Ignore matches in quoted strings like this:
        # elog "installed into ${ROOT}usr/share/php5/apc/."
-       re = re.compile(r'^[^#"\']*\b(dodir|dohard|exeinto|insinto|into)\s+"?\$\{?(D|ROOT|ED|EROOT|EPREFIX)\b.*')
+       re = re.compile(r'^[^#"\']*\b(docinto|docompress|dodir|dohard|exeinto|fowners|fperms|insinto|into)\s+"?\$\{?(D|ROOT|ED|EROOT|EPREFIX)\b.*')
        error = errors.NO_OFFSET_WITH_HELPERS
 
 class ImplicitRuntimeDeps(LineCheck):