Re: [PATCH v2 4/4] test: emacs: new test "notmuch-search: change tags of all matching...

diff --git a/1e/e4734e45f678b0658d47f687d1bd8e3dc9b3ca b/1e/e4734e45f678b0658d47f687d1bd8e3dc9b3ca
new file mode 100644 (file)
index 0000000..e47551f
--- /dev/null
+++ b/1e/e4734e45f678b0658d47f687d1bd8e3dc9b3ca
@@ -0,0 +1,151 @@
+Return-Path: <pieter@praet.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 4EE5E431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 22 Feb 2012 10:56:15 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 5D0L2sRMbegM for <notmuch@notmuchmail.org>;\r
+       Wed, 22 Feb 2012 10:56:14 -0800 (PST)\r
+Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com\r
+       [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 1A78A431FBD\r
+       for <notmuch@notmuchmail.org>; Wed, 22 Feb 2012 10:56:13 -0800 (PST)\r
+Received: by wibhi8 with SMTP id hi8so278196wib.26\r
+       for <notmuch@notmuchmail.org>; Wed, 22 Feb 2012 10:56:13 -0800 (PST)\r
+Received-SPF: pass (google.com: domain of pieter@praet.org designates\r
+       10.180.101.37 as permitted sender) client-ip=10.180.101.37; \r
+Authentication-Results: mr.google.com;\r
+       spf=pass (google.com: domain of pieter@praet.org\r
+       designates 10.180.101.37 as permitted sender)\r
+       smtp.mail=pieter@praet.org\r
+Received: from mr.google.com ([10.180.101.37])\r
+       by 10.180.101.37 with SMTP id fd5mr43888104wib.1.1329936973164\r
+       (num_hops = 1); Wed, 22 Feb 2012 10:56:13 -0800 (PST)\r
+Received: by 10.180.101.37 with SMTP id fd5mr36322257wib.1.1329936973107;\r
+       Wed, 22 Feb 2012 10:56:13 -0800 (PST)\r
+Received: from localhost ([109.131.181.26])\r
+       by mx.google.com with ESMTPS id ga1sm74964741wib.5.2012.02.22.10.56.12\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 22 Feb 2012 10:56:12 -0800 (PST)\r
+From: Pieter Praet <pieter@praet.org>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,\r
+       Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v2 4/4] test: emacs: new test "notmuch-search: change tags\r
+       of all matching messages"\r
+In-Reply-To: <87linxlmji.fsf@gmail.com>\r
+References: <1310313335-4159-1-git-send-email-pieter@praet.org>\r
+       <1329683908-5435-1-git-send-email-pieter@praet.org>\r
+       <1329683908-5435-5-git-send-email-pieter@praet.org>\r
+       <87linxlmji.fsf@gmail.com>\r
+User-Agent: Notmuch/0.11.1+210~g6afc43e (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+Date: Wed, 22 Feb 2012 19:53:55 +0100\r
+Message-ID: <87booq8zss.fsf@praet.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Gm-Message-State:\r
+ ALoCoQlPIH3A1lL2H1dPzkjkCyn5kutDth/ad87X3j29IDLPW3PgOfhtsyApty6zN0KWrGvDt6DP\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 22 Feb 2012 18:56:15 -0000\r
+\r
+On Mon, 20 Feb 2012 16:25:05 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> On Sun, 19 Feb 2012 21:38:28 +0100, Pieter Praet <pieter@praet.org> wrote:\r
+> > `notmuch-search-tag-all' (bound to "*") adds and removes tags\r
+> > to/from all messages which match the query used to populate the\r
+> > current search buffer.\r
+> \r
+> LGTM.  But since you will need to send a new version to address Tomi's\r
+> comments anyway, below are few minor comments.\r
+> \r
+> Regards,\r
+>   Dmitry\r
+> \r
+> > ---\r
+> >  test/emacs |   32 ++++++++++++++++++++++++++++++++\r
+> >  1 files changed, 32 insertions(+), 0 deletions(-)\r
+> > \r
+> > diff --git a/test/emacs b/test/emacs\r
+> > index b0fb760..1db8540 100755\r
+> > --- a/test/emacs\r
+> > +++ b/test/emacs\r
+> > @@ -124,6 +124,38 @@ test_emacs "(notmuch-show \"$os_x_darwin_thread\")\r
+> >  output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize)\r
+> >  test_expect_equal "$output" "thread:XXX   2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)"\r
+> >  \r
+> > +test_begin_subtest "notmuch-search: change tags of all matching messages"\r
+> > +old_tag="inbox"\r
+> > +new_tag="xobni"\r
+> > +filter="AND from:cworth"\r
+> > +# Get initial tag counts and prevent false positives/negatives\r
+> > +old_tag_count_1=$(notmuch count tag:"${old_tag}" "${filter}")\r
+> > +new_tag_count_1=$(notmuch count tag:"${new_tag}" "${filter}")\r
+> > +test "${old_tag_count_1}" == "0" && old_tag_count_1="Need 1+ matches!"\r
+> \r
+> Consider s/1+/>0/.\r
+> \r
+> > +test "${new_tag_count_1}" == "0" || new_tag_count_1="Need 0 matches!"\r
+> > +# Change tags of all matching messages and get tag counts\r
+> > +test_emacs "(notmuch-search \"tag:${old_tag} ${filter}\")\r
+> > +      (notmuch-test-wait)\r
+> > +      (notmuch-search-tag-all \"-${old_tag}\" \"+${new_tag}\")"\r
+> > +old_tag_count_2=$(notmuch count tag:"${old_tag}" "${filter}")\r
+> > +new_tag_count_2=$(notmuch count tag:"${new_tag}" "${filter}")\r
+> > +# Revert tag changes and get tag counts\r
+> > +test_emacs "(notmuch-search \"tag:${new_tag} ${filter}\")\r
+> > +      (notmuch-test-wait)\r
+> > +      (notmuch-search-tag-all \"+${old_tag}\" \"-${new_tag}\")"\r
+> > +old_tag_count_3=$(notmuch count tag:"${old_tag}" "${filter}")\r
+> > +new_tag_count_3=$(notmuch count tag:"${new_tag}" "${filter}")\r
+> > +# ... and verify the results\r
+> > +output="\r
+> > +before:   old:${old_tag_count_1} new:${new_tag_count_1}\r
+> > +after:    old:${old_tag_count_2} new:${new_tag_count_2}\r
+> > +restored: old:${old_tag_count_3} new:${new_tag_count_3}"\r
+> > +expected="\r
+> > +before:   old:${old_tag_count_1} new:0\r
+> > +after:    old:0 new:${old_tag_count_1}\r
+> > +restored: old:${old_tag_count_1} new:0"\r
+> > +test_expect_equal "$output" "$expected"\r
+> > +\r
+> \r
+> I would add a newline before every commented block.\r
+>\r
+\r
+Agreed, on all accounts.\r
+\r
+\r
+> Regards,\r
+>   Dmitry\r
+> \r
+> >  test_begin_subtest "Message with .. in Message-Id:"\r
+> >  add_message [id]=123..456@example '[subject]="Message with .. in Message-Id"'\r
+> >  test_emacs '(notmuch-search "id:\"123..456@example\"")\r
+> > -- \r
+> > 1.7.8.1\r
+> > \r
+\r
+\r
+Peace\r
+\r
+-- \r
+Pieter\r