reply --format=headers-only: set In-Reply-To header, with ID *last* in References
authorJed Brown <jed@59A2.org>
Wed, 25 Nov 2009 18:02:18 +0000 (19:02 +0100)
committerCarl Worth <cworth@cworth.org>
Sat, 28 Nov 2009 00:56:51 +0000 (16:56 -0800)
Apparently this is actually the correct way to do it, it's silly to do
it wrong just to conform to one of git's internal data structures.

notmuch-reply.c

index e85568c082ef8d519c1e391221e29867fc02d2aa..9ca1236b9c1791aec6d0ba88ba250e9773cf0689 100644 (file)
@@ -310,15 +310,19 @@ notmuch_reply_format_headers_only(void *ctx, notmuch_config_t *config, notmuch_q
        in_reply_to = talloc_asprintf (ctx, "<%s>",
                             notmuch_message_get_message_id (message));
 
+        g_mime_object_set_header (GMIME_OBJECT (reply),
+                                 "In-Reply-To", in_reply_to);
+
+
        orig_references = notmuch_message_get_header (message, "references");
 
-       /* We print References first because git format-patch treats it specially.
-        * Git uses the first entry of References to create In-Reply-To.
+       /* We print In-Reply-To followed by References because git format-patch treats them
+         * specially.  Git does not interpret the other headers specially
         */
        references = talloc_asprintf (ctx, "%s%s%s",
-                                     in_reply_to,
                                      orig_references ? orig_references : "",
-                                     orig_references ? " " : "");
+                                     orig_references ? " " : "",
+                                     in_reply_to);
        g_mime_object_set_header (GMIME_OBJECT (reply),
                                  "References", references);