Cleanup style nit of 'x == NULL' in remote.c
authorShawn O. Pearce <spearce@spearce.org>
Tue, 25 Sep 2007 04:13:14 +0000 (00:13 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 25 Sep 2007 06:25:15 +0000 (23:25 -0700)
Git style tends to prefer "!x" over "x == NULL".  Make it so in
these handful of locations that were not following along.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
remote.c

index e3c3df556d540db887d0b0291a306fe073065d41..ac354f37959361a3d7ea9cd97198a487a4e3e176 100644 (file)
--- a/remote.c
+++ b/remote.c
@@ -416,7 +416,7 @@ int remote_find_tracking(struct remote *remote, struct refspec *refspec)
        int i;
 
        if (find_src) {
-               if (refspec->dst == NULL)
+               if (!refspec->dst)
                        return error("find_tracking: need either src or dst");
                needle = refspec->dst;
                result = &refspec->src;
@@ -613,7 +613,7 @@ static int match_explicit(struct ref *src, struct ref *dst,
        if (!matched_src)
                errs = 1;
 
-       if (dst_value == NULL)
+       if (!dst_value)
                dst_value = matched_src->name;
 
        switch (count_refspec_match(dst_value, dst, &matched_dst)) {
@@ -633,7 +633,7 @@ static int match_explicit(struct ref *src, struct ref *dst,
                      dst_value);
                break;
        }
-       if (errs || matched_dst == NULL)
+       if (errs || !matched_dst)
                return 1;
        if (matched_dst->peer_ref) {
                errs = 1;