Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version...

diff --git a/87/4570ad4a69111cdd1bd488d2fbbc278bd696dd b/87/4570ad4a69111cdd1bd488d2fbbc278bd696dd
new file mode 100644 (file)
index 0000000..f91534a
--- /dev/null
+++ b/87/4570ad4a69111cdd1bd488d2fbbc278bd696dd
@@ -0,0 +1,73 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1CD6B431FBC\r
+       for <notmuch@notmuchmail.org>; Sun,  6 Apr 2014 11:43:32 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Lq+zPDc+FiBt for <notmuch@notmuchmail.org>;\r
+       Sun,  6 Apr 2014 11:43:23 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+       [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 93333431FB6\r
+       for <notmuch@notmuchmail.org>; Sun,  6 Apr 2014 11:43:23 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+       4.72) (envelope-from <david@tethera.net>)\r
+       id 1WWs1N-0004eg-FW; Sun, 06 Apr 2014 18:42:21 +0000\r
+Received: (nullmailer pid 10092 invoked by uid 1000); Sun, 06 Apr 2014\r
+       18:42:06 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create\r
+       notmuch-version.el from it\r
+In-Reply-To: <1395261431-24668-2-git-send-email-tomi.ollila@iki.fi>\r
+References: <1395261431-24668-1-git-send-email-tomi.ollila@iki.fi>\r
+       <1395261431-24668-2-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.17+170~gf516b7c (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 06 Apr 2014 15:42:06 -0300\r
+Message-ID: <87a9by47wh.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 06 Apr 2014 18:43:32 -0000\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> +;; You should have received a copy of the GNU General Public License\r
+> +;; along with Notmuch.  If not, see <http://www.gnu.org/licenses/>.\r
+\r
+Do you think we need a copyright header in a generated file?\r
+\r
+> +\r
+> +(defconst notmuch-emacs-version %VERSION%\r
+> +  "Version string of this version of Notmuch Emacs MUA.")\r
+> +\r
+\r
+At the risk of being very picky, how about less copies of Version, maybe\r
+"Version of Notmuch Emacs MUA"\r
+\r
+Other than that, the series looks OK, and works on Debian now.\r
+\r
+d\r
+\r