--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 4E6F5429E40\r
+ for <notmuch@notmuchmail.org>; Tue, 4 Nov 2014 01:24:11 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id Vg2Q+4do3GfT for <notmuch@notmuchmail.org>;\r
+ Tue, 4 Nov 2014 01:24:05 -0800 (PST)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id 1992C429E3B\r
+ for <notmuch@notmuchmail.org>; Tue, 4 Nov 2014 01:24:05 -0800 (PST)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1XlaL1-0002DN-Jk; Tue, 04 Nov 2014 09:24:03 +0000\r
+Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1XlaL1-0007Dk-4s; Tue, 04 Nov 2014 09:23:43 +0000\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 00/10] "notmuch address" command\r
+In-Reply-To: <1415058622-21162-1-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <1415058622-21162-1-git-send-email-sojkam1@fel.cvut.cz>\r
+User-Agent: Notmuch/0.18.1+86~gef5e66a (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 04 Nov 2014 09:23:42 +0000\r
+Message-ID: <87oasn2uap.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 87.81.223.162\r
+X-QM-Geographic: According to ripencc,\r
+ this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: b6037c5c405dfeacc0a4b3464d1c2425 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.1\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -0.1 points.\r
+ Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 04 Nov 2014 09:24:11 -0000\r
+\r
+\r
+On Mon, 03 Nov 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+> Hi all,\r
+>\r
+> this is v2 of "notmuch address" patchset. It obsoletes [1].\r
+>\r
+> Don't be scared by the number of patches. Most of them are trivial\r
+> refactoring. Patches 1-4 refactor the code so that "notmuch search"\r
+> command is easier to split. Patch 5 is Jani's hierarchical command\r
+> line parsing patch. Patch 6 splits search functionality to new address\r
+> command. Patch 7 is minor refactoring. Patches 8-10 correspond to\r
+> patches 5-7 in the original "notmuch search\r
+> --output=sender/recipients" patch series [2].\r
+>\r
+> Changes from v1:\r
+>\r
+> - Rebased to current master (conflicted with Jani's "notmuch search\r
+> --duplicate=N with --output=messages" patch)\r
+> - Fixed printing of false "Unrecognized option" error message in\r
+> hierarchical command line parser.\r
+\r
+Overall this series looks good. My inclination is to leave patch 10\r
+until after the freeze but I am happy either way. Tests all work and my\r
+testing is fine. \r
+\r
+A couple of other comments:\r
+\r
+you should add something to devel/schemata detailing the fields in the\r
+structured address output.\r
+\r
+Please check the new manpage: I think some of it is slightly outdated. I\r
+mentioned in my comments the exclude=false, but missed exclude=all. Also\r
+the manpage could say what actually gets printed in the default text\r
+case (in particular to emphasise that it includes the real name)\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+>\r
+> Regards,\r
+> -Michal\r
+>\r
+> [1] id:1414889400-30977-1-git-send-email-sojkam1@fel.cvut.cz\r
+> [2] id:1414792441-29555-1-git-send-email-sojkam1@fel.cvut.cz\r
+>\r
+>\r
+> Jani Nikula (1):\r
+> cli: add support for hierarchical command line option arrays\r
+>\r
+> Michal Sojka (9):\r
+> cli: search: Rename options to context\r
+> cli: search: Move more variables into search_context_t\r
+> cli: search: Convert ctx. to ctx->\r
+> cli: search: Split notmuch_search_command to smaller functions\r
+> cli: Introduce "notmuch address" command\r
+> cli: search: Convert --output to keyword argument\r
+> cli: address: Do not output duplicate addresses\r
+> cli: address: Add --output=count\r
+> cli: address: Add --filter-by option to configure address filtering\r
+>\r
+> command-line-arguments.c | 16 +-\r
+> command-line-arguments.h | 1 +\r
+> completion/notmuch-completion.bash | 48 +++-\r
+> completion/notmuch-completion.zsh | 11 +-\r
+> doc/man1/notmuch-address.rst | 140 ++++++++++++\r
+> doc/man1/notmuch-search.rst | 21 +-\r
+> doc/man1/notmuch.rst | 7 +-\r
+> notmuch-client.h | 3 +\r
+> notmuch-search.c | 454 +++++++++++++++++++++++++------------\r
+> notmuch.c | 2 +\r
+> test/T095-address.sh | 148 ++++++++++++\r
+> test/T097-address-filter-by.sh | 73 ++++++\r
+> 12 files changed, 751 insertions(+), 173 deletions(-)\r
+> create mode 100644 doc/man1/notmuch-address.rst\r
+> create mode 100755 test/T095-address.sh\r
+> create mode 100755 test/T097-address-filter-by.sh\r
+>\r
+> -- \r
+> 2.1.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff