projects / git.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 872354d) | patch
gitweb: do not run "git diff" that is Porcelain
authorJunio C Hamano <gitster@pobox.com>
Wed, 17 Dec 2008 03:42:02 +0000 (19:42 -0800)
committerJunio C Hamano <gitster@pobox.com>
Wed, 17 Dec 2008 05:54:44 +0000 (21:54 -0800)
commitdfff4b7aa42de7e7d58caeebe2c6128449f09b76
tree4bf8fbc8a9bffd10627fceb57cc972e4cbbdd8f8tree | snapshot
parent872354dcb3ce5f34f7ddb12d2c89d26a1ea4daf0commit | diff
gitweb: do not run "git diff" that is Porcelain

Jakub says that legacy-style URI to view two blob differences are never
generated since 1.4.3.  This codepath runs "git diff" Porcelain from the
gitweb, which is a no-no.  It can trigger diff.external command that is
specified in the configuration file of the repository being viewed.

This patch applies to v1.5.4 and later.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
gitweb/gitweb.perl diff | blob | history
Git—the stupid content tracker