Fix embarrassing "git log --follow" bug
authorLinus Torvalds <torvalds@linux-foundation.org>
Mon, 8 Oct 2007 20:42:41 +0000 (13:42 -0700)
committerShawn O. Pearce <spearce@spearce.org>
Tue, 16 Oct 2007 00:15:58 +0000 (20:15 -0400)
commit99516e35d096f41e7133cacde8fbed8ee9a3ecd0
treeba3f0ba08a32a68499c277a26aa65473f18cddf7
parent4c75136f7697f76b31641db775163f5c75906ee2
Fix embarrassing "git log --follow" bug

It turns out that I completely broke "git log --follow" with my recent
patch to revision.c ("Fix revision log diff setup, avoid unnecessary diff
generation", commit b7bb760d5ed4881422673d32f869d140221d3564).

Why? Because --follow obviously requires the diff machinery to function,
exactly the same way pickaxe does.

So everybody is away right now, but considering that nobody even noticed
this bug, I don't think it matters. But for the record, here's the trivial
one-liner fix (well, two, since I also fixed the comment).

Because of the nature of the bug, if you ask for patches when following
(which is one of the things I normally do), the bug is hidden, because
then the request for diff output will automatically also enable the diffs
themselves.

So while "git log --follow <filename>" didn't work, adding a "-p"
magically made it work again even without this fix.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
revision.c