fetch: use argv_array instead of hand-building arrays
authorJeff King <peff@peff.net>
Sat, 1 Sep 2012 11:27:35 +0000 (07:27 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 3 Sep 2012 04:11:48 +0000 (21:11 -0700)
commit85556d4e37db4c8ed88c68a602f6f85054996bea
tree51cda43510b3485c09391886d667a9bccc5dda7e
parentba4d1c7b1623b2c7ec198aee08036acf779375e6
fetch: use argv_array instead of hand-building arrays

Fetch invokes itself recursively when recursing into
submodules or handling "fetch --multiple". In both cases, it
builds the child's command line by pushing options onto a
statically-sized array. In both cases, the array is
currently just big enough to handle the largest possible
case. However, this technique is brittle and error-prone, so
let's replace it with a dynamic argv_array.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/fetch.c