git p4: refactor diffOpts calculation
authorGary Gibbons <ggibbons@perforce.com>
Wed, 4 Jul 2012 13:40:19 +0000 (09:40 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 6 Jul 2012 06:23:28 +0000 (23:23 -0700)
commit84cb00036fb59cf0ff305dcc27551f0519b5098c
tree7664cd1b9d9f86ba65c8079d93b4da1f6721010b
parenta0327c0edc7ada60ae2af5ec8daa5dcfcacd095d
git p4: refactor diffOpts calculation

P4Submit.applyCommit()

To avoid recalculating the same diffOpts for each commit, move it
out of applyCommit() and into the top-level run().  Also fix a bug
in that code which interpreted the value of detectRenames as a
string rather than as a boolean.

[pw: fix documentation, rearrange code a bit]

Signed-off-by: Gary Gibbons <ggibbons@perforce.com>
Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Documentation/git-p4.txt
git-p4.py