reply: Remove extraneous space from generated References
authorAustin Clements <amdragon@MIT.EDU>
Fri, 16 Aug 2013 15:35:42 +0000 (11:35 -0400)
committerDavid Bremner <bremner@debian.org>
Sat, 17 Aug 2013 07:05:44 +0000 (09:05 +0200)
commit6cdab6e0b77041791f70345ac729d63d865bae5e
treedfa453493e1688d390b3fb5dc829ea14327be054
parentad7bb423fb26f2b2fb801d3c2e3ceef9c7e3e622
reply: Remove extraneous space from generated References

Previously, the References header code seemed to assume
notmuch_message_get_header would return NULL if the header was not
present, but it actually returns "".  As a result of this, it was
inserting an unnecessary space when concatenating an empty or missing
original references header with the new reference.

This shows up in only two tests because the text reply format later
passes the whole reply template through g_mime_filter_headers, which
has the side effect of stripping out this extra space.
notmuch-reply.c
test/multipart
test/reply