replace direct calls to unlink(2) with unlink_or_warn
authorAlex Riesen <raa.lkml@gmail.com>
Wed, 29 Apr 2009 21:22:56 +0000 (23:22 +0200)
committerJunio C Hamano <gitster@pobox.com>
Thu, 30 Apr 2009 01:37:41 +0000 (18:37 -0700)
commit691f1a28bf57618d8b44a193b1d28013c858aba6
tree7d404656089320d486f658d3f4c061cd13dff556
parentfc71db39e0d75e8a403f36f3fecf4450886cd165
replace direct calls to unlink(2) with unlink_or_warn

This helps to notice when something's going wrong, especially on
systems which lock open files.

I used the following criteria when selecting the code for replacement:
- it was already printing a warning for the unlink failures
- it is in a function which already printing something or is
  called from such a function
- it is in a static function, returning void and the function is only
  called from a builtin main function (cmd_)
- it is in a function which handles emergency exit (signal handlers)
- it is in a function which is obvously cleaning up the lockfiles

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
23 files changed:
builtin-apply.c
builtin-fetch-pack.c
builtin-prune-packed.c
builtin-prune.c
builtin-receive-pack.c
builtin-remote.c
builtin-rerere.c
builtin-tag.c
builtin-verify-tag.c
diff.c
entry.c
fast-import.c
http-push.c
http-walker.c
ll-merge.c
lockfile.c
pack-refs.c
refs.c
rerere.c
server-info.c
sha1_file.c
transport.c
unpack-trees.c