diff-index.c: "git diff" has no need to read blob from the standard input
authorJunio C Hamano <gitster@pobox.com>
Thu, 28 Jun 2012 03:14:47 +0000 (20:14 -0700)
committerJunio C Hamano <gitster@pobox.com>
Thu, 28 Jun 2012 23:18:19 +0000 (16:18 -0700)
commit4682d8521c3ce9d722bd214fd7d5fc92063fdacb
tree1d3030f460c38d95eec40bc80d162acfa54a592a
parent3b069b1beba6d851401032260a8030448637ece5
diff-index.c: "git diff" has no need to read blob from the standard input

Only "diff --no-index -" does.  Bolting the logic into the low-level
function diff_populate_filespec() was a layering violation from day
one.  Move populate_from_stdin() function out of the generic diff.c
to its only user, diff-index.c.

Also make sure "-" from the command line stays a special token "read
from the standard input", even if we later decide to sanitize the
result from prefix_filename() function in a few obvious ways,
e.g. removing unnecessary "./" prefix, duplicated slashes "//" in
the middle, etc.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff-no-index.c
diff.c
diffcore.h
t/t7501-commit.sh