tests: do not use implicit "git diff --no-index"
authorJunio C Hamano <gitster@pobox.com>
Sat, 24 May 2008 05:28:56 +0000 (22:28 -0700)
committerJunio C Hamano <gitster@pobox.com>
Sat, 24 May 2008 07:01:56 +0000 (00:01 -0700)
commit3af828634fa5bdbca1b2061a81df8b3fa73b0d34
treef4d4a50e8c1686b3ecd796a09f98cc6ca13bc907
parent998b912927281a871e8d379e2b3a4385c775c4fe
tests: do not use implicit "git diff --no-index"

As a general principle, we should not use "git diff" to validate the
results of what git command that is being tested has done.  We would not
know if we are testing the command in question, or locating a bug in the
cute hack of "git diff --no-index".

Rather use test_cmp for that purpose.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
50 files changed:
t/diff-lib.sh
t/t0030-stripspace.sh
t/t0040-parse-options.sh
t/t1000-read-tree-m-3way.sh
t/t1001-read-tree-m-2way.sh
t/t1002-read-tree-m-u-2way.sh
t/t1300-repo-config.sh
t/t1303-wacky-config.sh
t/t1502-rev-parse-parseopt.sh
t/t3001-ls-files-others-exclude.sh
t/t3002-ls-files-dashpath.sh
t/t3030-merge-recursive.sh
t/t3040-subprojects-basic.sh
t/t3100-ls-tree-restrict.sh
t/t3101-ls-tree-dirname.sh
t/t3300-funny-names.sh
t/t3900-i18n-commit.sh
t/t4006-diff-mode.sh
t/t4013-diff-various.sh
t/t4014-format-patch.sh
t/t4015-diff-whitespace.sh
t/t4016-diff-quote.sh
t/t4018-diff-funcname.sh
t/t4100-apply-stat.sh
t/t4104-apply-boundary.sh
t/t4115-apply-symlink.sh
t/t4116-apply-reverse.sh
t/t4117-apply-reject.sh
t/t4118-apply-empty-context.sh
t/t4200-rerere.sh
t/t5305-include-tag.sh
t/t5400-send-pack.sh
t/t5401-update-hooks.sh
t/t5503-tagfollow.sh
t/t5505-remote.sh
t/t5515-fetch-merge-logic.sh
t/t6006-rev-list-format.sh
t/t6023-merge-file.sh
t/t6024-recursive-merge.sh
t/t6029-merge-subtree.sh
t/t6120-describe.sh
t/t6200-fmt-merge-msg.sh
t/t6300-for-each-ref.sh
t/t7003-filter-branch.sh
t/t7004-tag.sh
t/t7102-reset.sh
t/t7502-status.sh
t/t9100-git-svn-basic.sh
t/t9300-fast-import.sh
t/t9600-cvsimport.sh